[RFC][PATCH] drm: add helper extracting SADs from EDID

2013-04-07 Thread Ville Syrjälä
On Sun, Apr 07, 2013 at 12:52:57PM +0200, Rafa? Mi?ecki wrote: > Some devices (ATI/AMD cards) don't want passing ELD struct to the > hardware but just require filling specific registers and then > hardware/firmware does the rest. In such a cases we need to read info > from SAD blocks and put them i

[RFC][PATCH] drm: add helper extracting SADs from EDID

2013-04-07 Thread Paul Menzel
Am Sonntag, den 07.04.2013, 14:11 +0200 schrieb Rafa? Mi?ecki: > Thanks for comments! > > 2013/4/7 Paul Menzel : > > Am Sonntag, den 07.04.2013, 12:52 +0200 schrieb Rafa? Mi?ecki: > >> +struct cea_sad *drm_edid_to_sad(struct edid *edid) > >> +{ > >> + struct cea_sad *sads = NULL; > > > > No ne

[RFC][PATCH] drm: add helper extracting SADs from EDID

2013-04-07 Thread Rafał Miłecki
Thanks for comments! 2013/4/7 Paul Menzel : > Am Sonntag, den 07.04.2013, 12:52 +0200 schrieb Rafa? Mi?ecki: >> +struct cea_sad *drm_edid_to_sad(struct edid *edid) >> +{ >> + struct cea_sad *sads = NULL; > > No need to set it NULL, as it gets assigned later on? Looks like in the > end there is

[RFC][PATCH] drm: add helper extracting SADs from EDID

2013-04-07 Thread Paul Menzel
Am Sonntag, den 07.04.2013, 12:52 +0200 schrieb Rafa? Mi?ecki: > Some devices (ATI/AMD cards) don't want passing ELD struct to the want to pass > hardware but just require filling specific registers and then at end: ?then *the* hardware? (I think) > hardware/firmware does the rest. In such a c

[RFC][PATCH] drm: add helper extracting SADs from EDID

2013-04-07 Thread Rafał Miłecki
2013/4/7 Rafa? Mi?ecki : > Some devices (ATI/AMD cards) don't want passing ELD struct to the > hardware but just require filling specific registers and then > hardware/firmware does the rest. In such a cases we need to read info > from SAD blocks and put them in the correct registers. If you wish

[RFC][PATCH] drm: add helper extracting SADs from EDID

2013-04-07 Thread Rafał Miłecki
2013/4/7 Boszormenyi Zoltan : > will there be a followup patch where this function is actually used? Sure :) It's just early patch post, with RFC, to see if I'm doing it the right way. -- Rafa?

[RFC][PATCH] drm: add helper extracting SADs from EDID

2013-04-07 Thread Boszormenyi Zoltan
Hi, will there be a followup patch where this function is actually used? Best regards, Zolt?n B?sz?rm?nyi 2013-04-07 12:52 keltez?ssel, Rafa? Mi?ecki ?rta: > Some devices (ATI/AMD cards) don't want passing ELD struct to the > hardware but just require filling specific registers and then > hardwa

[RFC][PATCH] drm: add helper extracting SADs from EDID

2013-04-07 Thread Rafał Miłecki
Some devices (ATI/AMD cards) don't want passing ELD struct to the hardware but just require filling specific registers and then hardware/firmware does the rest. In such a cases we need to read info from SAD blocks and put them in the correct registers. --- drivers/gpu/drm/drm_edid.c | 55 +++

Re: [RFC][PATCH] drm: add helper extracting SADs from EDID

2013-04-07 Thread Ville Syrjälä
On Sun, Apr 07, 2013 at 12:52:57PM +0200, Rafał Miłecki wrote: > Some devices (ATI/AMD cards) don't want passing ELD struct to the > hardware but just require filling specific registers and then > hardware/firmware does the rest. In such a cases we need to read info > from SAD blocks and put them i

Re: [RFC][PATCH] drm: add helper extracting SADs from EDID

2013-04-07 Thread Paul Menzel
Am Sonntag, den 07.04.2013, 14:11 +0200 schrieb Rafał Miłecki: > Thanks for comments! > > 2013/4/7 Paul Menzel : > > Am Sonntag, den 07.04.2013, 12:52 +0200 schrieb Rafał Miłecki: > >> +struct cea_sad *drm_edid_to_sad(struct edid *edid) > >> +{ > >> + struct cea_sad *sads = NULL; > > > > No ne

Re: [RFC][PATCH] drm: add helper extracting SADs from EDID

2013-04-07 Thread Rafał Miłecki
Thanks for comments! 2013/4/7 Paul Menzel : > Am Sonntag, den 07.04.2013, 12:52 +0200 schrieb Rafał Miłecki: >> +struct cea_sad *drm_edid_to_sad(struct edid *edid) >> +{ >> + struct cea_sad *sads = NULL; > > No need to set it NULL, as it gets assigned later on? Looks like in the > end there is

Re: [RFC][PATCH] drm: add helper extracting SADs from EDID

2013-04-07 Thread Paul Menzel
Am Sonntag, den 07.04.2013, 12:52 +0200 schrieb Rafał Miłecki: > Some devices (ATI/AMD cards) don't want passing ELD struct to the want to pass > hardware but just require filling specific registers and then at end: »then *the* hardware« (I think) > hardware/firmware does the rest. In such a c

Re: [RFC][PATCH] drm: add helper extracting SADs from EDID

2013-04-07 Thread Rafał Miłecki
2013/4/7 Rafał Miłecki : > Some devices (ATI/AMD cards) don't want passing ELD struct to the > hardware but just require filling specific registers and then > hardware/firmware does the rest. In such a cases we need to read info > from SAD blocks and put them in the correct registers. If you wish

Re: [RFC][PATCH] drm: add helper extracting SADs from EDID

2013-04-07 Thread Rafał Miłecki
2013/4/7 Boszormenyi Zoltan : > will there be a followup patch where this function is actually used? Sure :) It's just early patch post, with RFC, to see if I'm doing it the right way. -- Rafał ___ dri-devel mailing list dri-devel@lists.freedesktop.org

Re: [RFC][PATCH] drm: add helper extracting SADs from EDID

2013-04-07 Thread Boszormenyi Zoltan
Hi, will there be a followup patch where this function is actually used? Best regards, Zoltán Böszörményi 2013-04-07 12:52 keltezéssel, Rafał Miłecki írta: Some devices (ATI/AMD cards) don't want passing ELD struct to the hardware but just require filling specific registers and then hardware/f

[RFC][PATCH] drm: add helper extracting SADs from EDID

2013-04-07 Thread Rafał Miłecki
Some devices (ATI/AMD cards) don't want passing ELD struct to the hardware but just require filling specific registers and then hardware/firmware does the rest. In such a cases we need to read info from SAD blocks and put them in the correct registers. --- drivers/gpu/drm/drm_edid.c | 55 +++