Re: [RFC/PATCH] backlight: hx8357: prepare to conversion to gpiod API

2022-10-13 Thread Daniel Thompson
On Wed, Oct 12, 2022 at 01:34:38PM -0700, Dmitry Torokhov wrote: > On Mon, Oct 10, 2022 at 10:36:00PM +0200, Linus Walleij wrote: > > On Thu, Oct 6, 2022 at 12:05 PM Daniel Thompson > > wrote: > > > On Thu, Oct 06, 2022 at 11:03:15AM +0200, Linus Walleij wrote: > > > > On Tue, Oct 4, 2022 at 10:35

Re: [RFC/PATCH] backlight: hx8357: prepare to conversion to gpiod API

2022-10-12 Thread Dmitry Torokhov
On Mon, Oct 10, 2022 at 10:36:00PM +0200, Linus Walleij wrote: > On Thu, Oct 6, 2022 at 12:05 PM Daniel Thompson > wrote: > > On Thu, Oct 06, 2022 at 11:03:15AM +0200, Linus Walleij wrote: > > > On Tue, Oct 4, 2022 at 10:35 PM Dmitry Torokhov > > > wrote: > > > > > > > > Dmitry, could you fix thi

Re: [RFC/PATCH] backlight: hx8357: prepare to conversion to gpiod API

2022-10-10 Thread Linus Walleij
On Thu, Oct 6, 2022 at 12:05 PM Daniel Thompson wrote: > On Thu, Oct 06, 2022 at 11:03:15AM +0200, Linus Walleij wrote: > > On Tue, Oct 4, 2022 at 10:35 PM Dmitry Torokhov > > wrote: > > > > > > Dmitry, could you fix this? Just patch away in gpiolib-of.c. > > > > > > Sure, I'll add a few quirks.

Re: [RFC/PATCH] backlight: hx8357: prepare to conversion to gpiod API

2022-10-06 Thread Daniel Thompson
On Thu, Oct 06, 2022 at 11:03:15AM +0200, Linus Walleij wrote: > On Tue, Oct 4, 2022 at 10:35 PM Dmitry Torokhov > wrote: > > > > Dmitry, could you fix this? Just patch away in gpiolib-of.c. > > > > Sure, I'll add a few quirks. I wonder what is the best way to merge > > this? I can create a bunch

Re: [RFC/PATCH] backlight: hx8357: prepare to conversion to gpiod API

2022-10-06 Thread Linus Walleij
On Tue, Oct 4, 2022 at 10:35 PM Dmitry Torokhov wrote: > > Dmitry, could you fix this? Just patch away in gpiolib-of.c. > > Sure, I'll add a few quirks. I wonder what is the best way to merge > this? I can create a bunch of IBs to be pulled, or I can send quirks to > you/Bartosz and once they lan

Re: [RFC/PATCH] backlight: hx8357: prepare to conversion to gpiod API

2022-10-04 Thread Dmitry Torokhov
On Tue, Oct 04, 2022 at 09:50:25PM +0200, Linus Walleij wrote: > On Tue, Oct 4, 2022 at 2:54 PM Daniel Thompson > wrote: > > > > We need to know if i.MX is shipping device trees stored in flash, > > > or if they bundle it with the kernel. > > > > This part is frequently found in add-on boards so

Re: [RFC/PATCH] backlight: hx8357: prepare to conversion to gpiod API

2022-10-04 Thread Linus Walleij
On Tue, Oct 4, 2022 at 2:54 PM Daniel Thompson wrote: > > We need to know if i.MX is shipping device trees stored in flash, > > or if they bundle it with the kernel. > > This part is frequently found in add-on boards so it's not purely an > i.MX-only question. Oh > IMHO for not-in-the-soc devic

Re: [RFC/PATCH] backlight: hx8357: prepare to conversion to gpiod API

2022-10-04 Thread Daniel Thompson
On Tue, Oct 04, 2022 at 11:02:06AM +0200, Linus Walleij wrote: > On Wed, Sep 28, 2022 at 12:32 AM Dmitry Torokhov > wrote: > > > Properties describing GPIOs should be named as "-gpios" or > > "-gpio", and that is what gpiod API expects, however the > > driver uses non-standard "gpios-reset" name.

Re: [RFC/PATCH] backlight: hx8357: prepare to conversion to gpiod API

2022-10-04 Thread Linus Walleij
On Wed, Sep 28, 2022 at 12:32 AM Dmitry Torokhov wrote: > Properties describing GPIOs should be named as "-gpios" or > "-gpio", and that is what gpiod API expects, however the > driver uses non-standard "gpios-reset" name. Let's adjust this, and also > note that the reset line is active low as th

Re: [RFC/PATCH] backlight: hx8357: prepare to conversion to gpiod API

2022-10-03 Thread Daniel Thompson
On Wed, Sep 28, 2022 at 11:33:52AM -0700, Dmitry Torokhov wrote: > On Wed, Sep 28, 2022 at 12:00:51PM +0100, Daniel Thompson wrote: > > On Tue, Sep 27, 2022 at 03:32:35PM -0700, Dmitry Torokhov wrote: > > > Properties describing GPIOs should be named as "-gpios" or > > > "-gpio", and that is what g

Re: [RFC/PATCH] backlight: hx8357: prepare to conversion to gpiod API

2022-09-28 Thread Dmitry Torokhov
On Wed, Sep 28, 2022 at 12:00:51PM +0100, Daniel Thompson wrote: > On Tue, Sep 27, 2022 at 03:32:35PM -0700, Dmitry Torokhov wrote: > > Properties describing GPIOs should be named as "-gpios" or > > "-gpio", and that is what gpiod API expects, however the > > driver uses non-standard "gpios-reset"

Re: [RFC/PATCH] backlight: hx8357: prepare to conversion to gpiod API

2022-09-28 Thread Daniel Thompson
On Tue, Sep 27, 2022 at 03:32:35PM -0700, Dmitry Torokhov wrote: > Properties describing GPIOs should be named as "-gpios" or > "-gpio", and that is what gpiod API expects, however the > driver uses non-standard "gpios-reset" name. Let's adjust this, and also > note that the reset line is active lo

[RFC/PATCH] backlight: hx8357: prepare to conversion to gpiod API

2022-09-27 Thread Dmitry Torokhov
Properties describing GPIOs should be named as "-gpios" or "-gpio", and that is what gpiod API expects, however the driver uses non-standard "gpios-reset" name. Let's adjust this, and also note that the reset line is active low as that is also important to gpiod API. Signed-off-by: Dmitry Torokhov