Re: [RESEND PATCH v4] drm: Don't free jobs in wait_event_interruptible()

2019-10-25 Thread Koenig, Christian
Am 25.10.19 um 12:26 schrieb Steven Price: > On 25/10/2019 10:49, Koenig, Christian wrote: >> Am 24.10.19 um 18:24 schrieb Steven Price: >>> drm_sched_cleanup_jobs() attempts to free finished jobs, however because >>> it is called as the condition of wait_event_interruptible() it must not >>> sleep

Re: [RESEND PATCH v4] drm: Don't free jobs in wait_event_interruptible()

2019-10-25 Thread Steven Price
On 25/10/2019 10:49, Koenig, Christian wrote: > Am 24.10.19 um 18:24 schrieb Steven Price: >> drm_sched_cleanup_jobs() attempts to free finished jobs, however because >> it is called as the condition of wait_event_interruptible() it must not >> sleep. Unfortuantly some free callbacks (notibly for P

Re: [RESEND PATCH v4] drm: Don't free jobs in wait_event_interruptible()

2019-10-25 Thread Steven Price
On 25/10/2019 10:43, Christian Gmeiner wrote: > Am Do., 24. Okt. 2019 um 18:25 Uhr schrieb Steven Price > : >> >> drm_sched_cleanup_jobs() attempts to free finished jobs, however because >> it is called as the condition of wait_event_interruptible() it must not >> sleep. Unfortuantly some free cal

Re: [RESEND PATCH v4] drm: Don't free jobs in wait_event_interruptible()

2019-10-25 Thread Koenig, Christian
Am 24.10.19 um 18:24 schrieb Steven Price: > drm_sched_cleanup_jobs() attempts to free finished jobs, however because > it is called as the condition of wait_event_interruptible() it must not > sleep. Unfortuantly some free callbacks (notibly for Panfrost) do sleep. > > Instead let's rename drm_sch

Re: [RESEND PATCH v4] drm: Don't free jobs in wait_event_interruptible()

2019-10-25 Thread Christian Gmeiner
Am Do., 24. Okt. 2019 um 18:25 Uhr schrieb Steven Price : > > drm_sched_cleanup_jobs() attempts to free finished jobs, however because > it is called as the condition of wait_event_interruptible() it must not > sleep. Unfortuantly some free callbacks (notibly for Panfrost) do sleep. > > Instead let

[RESEND PATCH v4] drm: Don't free jobs in wait_event_interruptible()

2019-10-24 Thread Steven Price
drm_sched_cleanup_jobs() attempts to free finished jobs, however because it is called as the condition of wait_event_interruptible() it must not sleep. Unfortuantly some free callbacks (notibly for Panfrost) do sleep. Instead let's rename drm_sched_cleanup_jobs() to drm_sched_get_cleanup_job() and