On 2016-01-26 13:18, Emil Velikov wrote:
> On 14 January 2016 at 08:23, Meng Yi wrote:
>>> >> switch (fb->pixel_format) {
>>> >> case DRM_FORMAT_RGB565:
>>> >> case DRM_FORMAT_RGB888:
>>> >> @@ -85,9 +88,6 @@ static void fsl_dcu_drm_plane_atomic_update(struct
>>> drm_plane
On 14 January 2016 at 08:23, Meng Yi wrote:
>> >> switch (fb->pixel_format) {
>> >> case DRM_FORMAT_RGB565:
>> >> case DRM_FORMAT_RGB888:
>> >> @@ -85,9 +88,6 @@ static void fsl_dcu_drm_plane_atomic_update(struct
>> drm_plane *plane,
>> >> unsigned int alpha, bpp;
>
ate will ultimately called, and we'll crash since
plane->state->fb is NULL.
> -Original Message-
> From: Stefan Agner [mailto:stefan at agner.ch]
> Sent: Thursday, January 14, 2016 1:54 PM
> To: Emil Velikov
> Cc: Meng Yi ; ML dri-devel devel at lists.freedesktop.
On 2016-01-08 01:20, Emil Velikov wrote:
> Hi guys,
>
> Am I loosing the plot here or something feels amiss here ?
>
> On 6 January 2016 at 06:12, Meng Yi wrote:
>> For state->fb or state->crtc may be NULL in fsl_dcu_drm_plane_atomic_check
>> function, if so, return 0.
>>
>> Signed-off-by: Meng
Hi guys,
Am I loosing the plot here or something feels amiss here ?
On 6 January 2016 at 06:12, Meng Yi wrote:
> For state->fb or state->crtc may be NULL in fsl_dcu_drm_plane_atomic_check
> function, if so, return 0.
>
> Signed-off-by: Meng Yi
> Signed-off-by: Jianwei Wang
>
> ---
>
> change i
For state->fb or state->crtc may be NULL in fsl_dcu_drm_plane_atomic_check
function, if so, return 0.
Signed-off-by: Meng Yi
Signed-off-by: Jianwei Wang
---
change in v2:
-Add state->crtc check
-return 0 when state->fb or state->crtc is NULL, instead of -EINVAL
Adviced by Daniel Stone
driver
