Re: [Patch 1/1] drm/atomic: integrate private objects with suspend/resume helpers

2019-03-25 Thread Daniel Vetter
On Fri, Mar 15, 2019 at 06:56:07AM -0500, Benoit Parrot wrote: > Daniel Vetter wrote on Fri [2019-Mar-15 11:50:57 +0100]: > > On Thu, Mar 14, 2019 at 08:44:45AM -0500, Benoit Parrot wrote: > > > During a suspend cycle the atomic state is saved to be used during the > > > restore cycle. > > > > >

Re: [Patch 1/1] drm/atomic: integrate private objects with suspend/resume helpers

2019-03-15 Thread Benoit Parrot
Daniel Vetter wrote on Fri [2019-Mar-15 11:50:57 +0100]: > On Thu, Mar 14, 2019 at 08:44:45AM -0500, Benoit Parrot wrote: > > During a suspend cycle the atomic state is saved to be used during the > > restore cycle. > > > > However the current state duplication logic does not duplicate private >

Re: [Patch 1/1] drm/atomic: integrate private objects with suspend/resume helpers

2019-03-15 Thread Daniel Vetter
On Thu, Mar 14, 2019 at 08:44:45AM -0500, Benoit Parrot wrote: > During a suspend cycle the atomic state is saved to be used during the > restore cycle. > > However the current state duplication logic does not duplicate private > objects. This leads to state inconsistencies at resume time. > > Wi

Re: [Patch 1/1] drm/atomic: integrate private objects with suspend/resume helpers

2019-03-14 Thread Laurent Pinchart
Hi Benoit, Thank you for the patch. On Thu, Mar 14, 2019 at 08:44:45AM -0500, Benoit Parrot wrote: > During a suspend cycle the atomic state is saved to be used during the > restore cycle. > > However the current state duplication logic does not duplicate private > objects. This leads to state i

Re: [Patch 1/1] drm/atomic: integrate private objects with suspend/resume helpers

2019-03-14 Thread Benoit Parrot
Ville Syrjälä wrote on Thu [2019-Mar-14 17:31:29 +0200]: > On Thu, Mar 14, 2019 at 08:44:45AM -0500, Benoit Parrot wrote: > > During a suspend cycle the atomic state is saved to be used during the > > restore cycle. > > > > However the current state duplication logic does not duplicate private >

Re: [Patch 1/1] drm/atomic: integrate private objects with suspend/resume helpers

2019-03-14 Thread Ville Syrjälä
On Thu, Mar 14, 2019 at 08:44:45AM -0500, Benoit Parrot wrote: > During a suspend cycle the atomic state is saved to be used during the > restore cycle. > > However the current state duplication logic does not duplicate private > objects. This leads to state inconsistencies at resume time. > > Wi

[Patch 1/1] drm/atomic: integrate private objects with suspend/resume helpers

2019-03-14 Thread Benoit Parrot
During a suspend cycle the atomic state is saved to be used during the restore cycle. However the current state duplication logic does not duplicate private objects. This leads to state inconsistencies at resume time. With private objects modeset lock now integrated, we can make sure that private