[PULL] topic/vblank-rework, take 2

2014-10-08 Thread Thierry Reding
On Fri, Sep 12, 2014 at 09:48:59AM +0200, Daniel Vetter wrote: [...] > Ville Syrj?l? (16): > drm: Always reject drm_vblank_get() after drm_vblank_off() This particular commit seems to be wreaking havoc. Inki already reported this at some point and Andrzej and Joonyoung tried to fix this on E

[PULL] topic/vblank-rework, take 2

2014-09-12 Thread Daniel Vetter
Hi Dave, So updated vblank-rework pull request, now with the polish that Mario requested applied (and reviewed by him). Also with backmerge like you've requested for easier merging. The neat thing this finally allows is to immediately disable the vblank interrupt on the last drm_vblank_put if the

[Intel-gfx] [PULL] topic/vblank-rework

2014-09-11 Thread Daniel Vetter
Hi Mario, Can you please take a look at the patches I've submitted and review them (at least the first 2)? Dave will close the 3.18 drm-next merge window at the end of this week and I'd like to really get this in. Thanks, Daniel On Wed, Sep 10, 2014 at 5:45 PM, Mario Kleiner wrote: > On Wed, S

[Intel-gfx] [PULL] topic/vblank-rework

2014-09-10 Thread Mario Kleiner
On Wed, Sep 10, 2014 at 5:29 PM, Daniel Vetter wrote: > On Wed, Sep 10, 2014 at 4:19 PM, Mario Kleiner > wrote: >> Hmm, not quite an ack from my side for the pull in its current form. I >> said if the two remaining issues i mentioned are addressed, then i'm >> happy with it and can have my revie

[Intel-gfx] [PULL] topic/vblank-rework

2014-09-10 Thread Daniel Vetter
On Wed, Sep 10, 2014 at 4:19 PM, Mario Kleiner wrote: > Hmm, not quite an ack from my side for the pull in its current form. I > said if the two remaining issues i mentioned are addressed, then i'm > happy with it and can have my reviewed/acked-by. Looking at the code > they haven't been adressed.

[Intel-gfx] [PULL] topic/vblank-rework

2014-09-10 Thread Mario Kleiner
e-mail snafu, sent it too early by accident, and from a gmail web interface which i'm apparently incapable of using properly... The second fix should look like this: > A simple fix in static void vblank_disable_and_save() would be to > replace the new... > > if (!vblank->enabled) { > > ... check

[Intel-gfx] [PULL] topic/vblank-rework

2014-09-10 Thread Mario Kleiner
Hmm, not quite an ack from my side for the pull in its current form. I said if the two remaining issues i mentioned are addressed, then i'm happy with it and can have my reviewed/acked-by. Looking at the code they haven't been adressed. However, this is easily fixable on top of the current patches

[PULL] topic/vblank-rework

2014-09-10 Thread Daniel Vetter
Hi Dave, So here's the final bits of Ville's vblank rework with a bit of cleanup from Mario on top. The neat thing this finally allows is to immediately disable the vblank interrupt on the last drm_vblank_put if the hardware has perfectly accurate vblank counter and timestamp readout support. On