Re: [PATCHv6 3/6] drm/arm/malidp: Factor-in framebuffer creation

2020-03-06 Thread Emil Velikov
On Tue, 3 Mar 2020 at 16:51, Emil Velikov wrote: > > + objs = drm_gem_object_lookup(file, mode_cmd->handles[0]); > > + if (!objs) { > > + DRM_DEBUG_KMS("Failed to lookup GEM object\n"); > > + return ERR_PTR(-EINVAL); > > +

Re: [PATCHv6 3/6] drm/arm/malidp: Factor-in framebuffer creation

2020-03-03 Thread Emil Velikov
Hi Andrzej, On Tue, 3 Mar 2020 at 12:01, Andrzej Pietrasiewicz wrote: > > Consolidating framebuffer creation into one function will make it easier > to transition to generic afbc-aware helpers. > I'd suggest keeping the refactor a bit simpler. Say - first folds the functions together. Then do the

[PATCHv6 3/6] drm/arm/malidp: Factor-in framebuffer creation

2020-03-03 Thread Andrzej Pietrasiewicz
Consolidating framebuffer creation into one function will make it easier to transition to generic afbc-aware helpers. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/arm/malidp_drv.c | 158 +-- 1 file changed, 67 insertions(+), 91 deletions(-) diff --git a/d