Re: [PATCHv5 4/6] drm/omap: fix incorrect union usage

2018-11-26 Thread Tomi Valkeinen
On 21/11/18 18:09, Sebastian Reichel wrote: > The DSI encoder sets dssdev->ops->dsi.set_config, which is stored at the > same offset as dssdev->ops->hdmi.set_hdmi_mode. The code in omap_encoder > only checks if dssdev->ops->hdmi.set_hdmi_mode is NULL. Due to the way > union works, it won't be NULL

Re: [PATCHv5 4/6] drm/omap: fix incorrect union usage

2018-11-24 Thread Tony Lindgren
* Sebastian Reichel [181121 16:09]: > The DSI encoder sets dssdev->ops->dsi.set_config, which is stored at the > same offset as dssdev->ops->hdmi.set_hdmi_mode. The code in omap_encoder > only checks if dssdev->ops->hdmi.set_hdmi_mode is NULL. Due to the way > union works, it won't be NULL if dsi.

[PATCHv5 4/6] drm/omap: fix incorrect union usage

2018-11-22 Thread Sebastian Reichel
The DSI encoder sets dssdev->ops->dsi.set_config, which is stored at the same offset as dssdev->ops->hdmi.set_hdmi_mode. The code in omap_encoder only checks if dssdev->ops->hdmi.set_hdmi_mode is NULL. Due to the way union works, it won't be NULL if dsi.set_config is set. This means dsi_set_config