[PATCHv5,RESEND 4/8] gpu: host1x: Add debug support

2013-02-08 Thread Thierry Reding
On Wed, Feb 06, 2013 at 12:58:19PM -0800, Terje Bergstr?m wrote: > On 05.02.2013 01:15, Thierry Reding wrote: > > On Mon, Feb 04, 2013 at 08:41:25PM -0800, Terje Bergstr?m wrote: > >> This is used by debugfs code to direct to debugfs, and > >> nvhost_debug_dump() to send via printk. > > > > Yes, t

Re: [PATCHv5,RESEND 4/8] gpu: host1x: Add debug support

2013-02-07 Thread Thierry Reding
On Wed, Feb 06, 2013 at 12:58:19PM -0800, Terje Bergström wrote: > On 05.02.2013 01:15, Thierry Reding wrote: > > On Mon, Feb 04, 2013 at 08:41:25PM -0800, Terje Bergström wrote: > >> This is used by debugfs code to direct to debugfs, and > >> nvhost_debug_dump() to send via printk. > > > > Yes, t

Re: [PATCHv5,RESEND 4/8] gpu: host1x: Add debug support

2013-02-06 Thread Terje Bergström
On 05.02.2013 01:15, Thierry Reding wrote: > On Mon, Feb 04, 2013 at 08:41:25PM -0800, Terje Bergström wrote: >> This is used by debugfs code to direct to debugfs, and >> nvhost_debug_dump() to send via printk. > > Yes, that was precisely my point. Why bother providing the same data via > several

[PATCHv5,RESEND 4/8] gpu: host1x: Add debug support

2013-02-06 Thread Terje Bergström
On 05.02.2013 01:15, Thierry Reding wrote: > On Mon, Feb 04, 2013 at 08:41:25PM -0800, Terje Bergstr?m wrote: >> This is used by debugfs code to direct to debugfs, and >> nvhost_debug_dump() to send via printk. > > Yes, that was precisely my point. Why bother providing the same data via > several

[PATCHv5,RESEND 4/8] gpu: host1x: Add debug support

2013-02-05 Thread Thierry Reding
On Mon, Feb 04, 2013 at 08:41:25PM -0800, Terje Bergstr?m wrote: > On 04.02.2013 03:03, Thierry Reding wrote: > > On Tue, Jan 15, 2013 at 01:44:00PM +0200, Terje Bergstrom wrote: > >> diff --git a/drivers/gpu/host1x/debug.h b/drivers/gpu/host1x/debug.h > > [...] > >> +struct output { > >> + void (

Re: [PATCHv5,RESEND 4/8] gpu: host1x: Add debug support

2013-02-05 Thread Thierry Reding
On Mon, Feb 04, 2013 at 08:41:25PM -0800, Terje Bergström wrote: > On 04.02.2013 03:03, Thierry Reding wrote: > > On Tue, Jan 15, 2013 at 01:44:00PM +0200, Terje Bergstrom wrote: > >> diff --git a/drivers/gpu/host1x/debug.h b/drivers/gpu/host1x/debug.h > > [...] > >> +struct output { > >> + void (

Re: [PATCHv5,RESEND 4/8] gpu: host1x: Add debug support

2013-02-04 Thread Terje Bergström
On 04.02.2013 03:03, Thierry Reding wrote: > * PGP Signed by an unknown key > > On Tue, Jan 15, 2013 at 01:44:00PM +0200, Terje Bergstrom wrote: >> diff --git a/drivers/gpu/host1x/debug.c b/drivers/gpu/host1x/debug.c > [...] >> +static pid_t host1x_debug_null_kickoff_pid; >> +unsigned int host1x_d

[PATCHv5,RESEND 4/8] gpu: host1x: Add debug support

2013-02-04 Thread Terje Bergström
On 04.02.2013 03:03, Thierry Reding wrote: > * PGP Signed by an unknown key > > On Tue, Jan 15, 2013 at 01:44:00PM +0200, Terje Bergstrom wrote: >> diff --git a/drivers/gpu/host1x/debug.c b/drivers/gpu/host1x/debug.c > [...] >> +static pid_t host1x_debug_null_kickoff_pid; >> +unsigned int host1x_d

[PATCHv5,RESEND 4/8] gpu: host1x: Add debug support

2013-02-04 Thread Thierry Reding
On Tue, Jan 15, 2013 at 01:44:00PM +0200, Terje Bergstrom wrote: > diff --git a/drivers/gpu/host1x/debug.c b/drivers/gpu/host1x/debug.c [...] > +static pid_t host1x_debug_null_kickoff_pid; > +unsigned int host1x_debug_trace_cmdbuf; > + > +static pid_t host1x_debug_force_timeout_pid; > +static u32 h

Re: [PATCHv5,RESEND 4/8] gpu: host1x: Add debug support

2013-02-04 Thread Thierry Reding
On Tue, Jan 15, 2013 at 01:44:00PM +0200, Terje Bergstrom wrote: > diff --git a/drivers/gpu/host1x/debug.c b/drivers/gpu/host1x/debug.c [...] > +static pid_t host1x_debug_null_kickoff_pid; > +unsigned int host1x_debug_trace_cmdbuf; > + > +static pid_t host1x_debug_force_timeout_pid; > +static u32 h

[PATCHv5,RESEND 4/8] gpu: host1x: Add debug support

2013-01-15 Thread Terje Bergstrom
Add support for host1x debugging. Adds debugfs entries, and dumps channel state to UART in case of stuck job. Signed-off-by: Terje Bergstrom --- drivers/gpu/host1x/Makefile |1 + drivers/gpu/host1x/cdma.c | 34 +++ drivers/gpu/host1x/debug.c

[PATCHv5,RESEND 4/8] gpu: host1x: Add debug support

2013-01-15 Thread Terje Bergstrom
Add support for host1x debugging. Adds debugfs entries, and dumps channel state to UART in case of stuck job. Signed-off-by: Terje Bergstrom --- drivers/gpu/host1x/Makefile |1 + drivers/gpu/host1x/cdma.c | 34 +++ drivers/gpu/host1x/debug.c