[PATCHv5,RESEND 3/8] gpu: host1x: Add channel support

2013-03-11 Thread Terje Bergström
On 11.03.2013 09:18, Thierry Reding wrote: > This sound a bit over-engineered at this point in time. DRM is currently > the only user. Is anybody working on any non-DRM drivers that would use > this? Well, this contains beginning of that: http://nv-tegra.nvidia.com/gitweb/?p=linux-2.6.git;a=blob;

[PATCHv5,RESEND 3/8] gpu: host1x: Add channel support

2013-03-11 Thread Thierry Reding
On Mon, Mar 11, 2013 at 11:21:05AM +0200, Terje Bergstr?m wrote: > On 11.03.2013 09:18, Thierry Reding wrote: > > This sound a bit over-engineered at this point in time. DRM is currently > > the only user. Is anybody working on any non-DRM drivers that would use > > this? > > Well, this contains b

[PATCHv5,RESEND 3/8] gpu: host1x: Add channel support

2013-03-11 Thread Terje Bergström
On 08.03.2013 22:43, Thierry Reding wrote: > A bo is just a buffer object, so I don't see why the name shouldn't > be used. The name is in no way specific to DRM or GEM. But the point > that I was trying to make was that there is nothing to suggest that > we couldn't use drm_gem_object as the under

[PATCHv5,RESEND 3/8] gpu: host1x: Add channel support

2013-03-11 Thread Thierry Reding
On Mon, Mar 11, 2013 at 08:29:59AM +0200, Terje Bergstr?m wrote: > On 08.03.2013 22:43, Thierry Reding wrote: > > A bo is just a buffer object, so I don't see why the name shouldn't > > be used. The name is in no way specific to DRM or GEM. But the point > > that I was trying to make was that there

Re: [PATCHv5,RESEND 3/8] gpu: host1x: Add channel support

2013-03-11 Thread Thierry Reding
On Mon, Mar 11, 2013 at 11:21:05AM +0200, Terje Bergström wrote: > On 11.03.2013 09:18, Thierry Reding wrote: > > This sound a bit over-engineered at this point in time. DRM is currently > > the only user. Is anybody working on any non-DRM drivers that would use > > this? > > Well, this contains b

Re: [PATCHv5,RESEND 3/8] gpu: host1x: Add channel support

2013-03-11 Thread Terje Bergström
On 11.03.2013 09:18, Thierry Reding wrote: > This sound a bit over-engineered at this point in time. DRM is currently > the only user. Is anybody working on any non-DRM drivers that would use > this? Well, this contains beginning of that: http://nv-tegra.nvidia.com/gitweb/?p=linux-2.6.git;a=blob;

Re: [PATCHv5,RESEND 3/8] gpu: host1x: Add channel support

2013-03-11 Thread Thierry Reding
On Mon, Mar 11, 2013 at 08:29:59AM +0200, Terje Bergström wrote: > On 08.03.2013 22:43, Thierry Reding wrote: > > A bo is just a buffer object, so I don't see why the name shouldn't > > be used. The name is in no way specific to DRM or GEM. But the point > > that I was trying to make was that there

Re: [PATCHv5,RESEND 3/8] gpu: host1x: Add channel support

2013-03-10 Thread Terje Bergström
On 08.03.2013 22:43, Thierry Reding wrote: > A bo is just a buffer object, so I don't see why the name shouldn't > be used. The name is in no way specific to DRM or GEM. But the point > that I was trying to make was that there is nothing to suggest that > we couldn't use drm_gem_object as the under

[PATCHv5,RESEND 3/8] gpu: host1x: Add channel support

2013-03-08 Thread Thierry Reding
On Fri, Mar 08, 2013 at 06:16:16PM +0200, Terje Bergstr?m wrote: > On 26.02.2013 11:48, Terje Bergstr?m wrote: > > On 25.02.2013 17:24, Thierry Reding wrote: [...] > >>> +struct mem_handle; > >>> +struct platform_device; > >>> + > >>> +struct host1x_job_unpin_data { > >>> + struct mem_handle *h

[PATCHv5,RESEND 3/8] gpu: host1x: Add channel support

2013-03-08 Thread Terje Bergström
On 26.02.2013 11:48, Terje Bergstr?m wrote: > On 25.02.2013 17:24, Thierry Reding wrote: >> You use two different styles to indent the function parameters. You >> might want to stick to one, preferably aligning them with the first >> parameter on the first line. > > I've generally favored "two tab

Re: [PATCHv5,RESEND 3/8] gpu: host1x: Add channel support

2013-03-08 Thread Thierry Reding
On Fri, Mar 08, 2013 at 06:16:16PM +0200, Terje Bergström wrote: > On 26.02.2013 11:48, Terje Bergström wrote: > > On 25.02.2013 17:24, Thierry Reding wrote: [...] > >>> +struct mem_handle; > >>> +struct platform_device; > >>> + > >>> +struct host1x_job_unpin_data { > >>> + struct mem_handle *h

Re: [PATCHv5,RESEND 3/8] gpu: host1x: Add channel support

2013-03-08 Thread Terje Bergström
On 26.02.2013 11:48, Terje Bergström wrote: > On 25.02.2013 17:24, Thierry Reding wrote: >> You use two different styles to indent the function parameters. You >> might want to stick to one, preferably aligning them with the first >> parameter on the first line. > > I've generally favored "two tab

[PATCHv5,RESEND 3/8] gpu: host1x: Add channel support

2013-02-27 Thread Thierry Reding
On Tue, Feb 26, 2013 at 11:48:18AM +0200, Terje Bergstr?m wrote: > On 25.02.2013 17:24, Thierry Reding wrote: > > On Tue, Jan 15, 2013 at 01:43:59PM +0200, Terje Bergstrom wrote: [...] > >> +/* > >> + * Start timer for a buffer submition that has completed yet. > > > > "submission". And I don't un

Re: [PATCHv5,RESEND 3/8] gpu: host1x: Add channel support

2013-02-27 Thread Thierry Reding
On Tue, Feb 26, 2013 at 11:48:18AM +0200, Terje Bergström wrote: > On 25.02.2013 17:24, Thierry Reding wrote: > > On Tue, Jan 15, 2013 at 01:43:59PM +0200, Terje Bergstrom wrote: [...] > >> +/* > >> + * Start timer for a buffer submition that has completed yet. > > > > "submission". And I don't un

[PATCHv5,RESEND 3/8] gpu: host1x: Add channel support

2013-02-26 Thread Terje Bergström
On 25.02.2013 17:24, Thierry Reding wrote: > * PGP Signed by an unknown key > > On Tue, Jan 15, 2013 at 01:43:59PM +0200, Terje Bergstrom wrote: > [...] >> diff --git a/drivers/gpu/host1x/Kconfig b/drivers/gpu/host1x/Kconfig >> index e89fb2b..57680a6 100644 >> --- a/drivers/gpu/host1x/Kconfig >> +

[PATCHv5,RESEND 3/8] gpu: host1x: Add channel support

2013-02-25 Thread Thierry Reding
On Tue, Jan 15, 2013 at 01:43:59PM +0200, Terje Bergstrom wrote: [...] > diff --git a/drivers/gpu/host1x/Kconfig b/drivers/gpu/host1x/Kconfig > index e89fb2b..57680a6 100644 > --- a/drivers/gpu/host1x/Kconfig > +++ b/drivers/gpu/host1x/Kconfig > @@ -3,4 +3,27 @@ config TEGRA_HOST1X > help >

Re: [PATCHv5,RESEND 3/8] gpu: host1x: Add channel support

2013-02-25 Thread Thierry Reding
On Tue, Jan 15, 2013 at 01:43:59PM +0200, Terje Bergstrom wrote: [...] > diff --git a/drivers/gpu/host1x/Kconfig b/drivers/gpu/host1x/Kconfig > index e89fb2b..57680a6 100644 > --- a/drivers/gpu/host1x/Kconfig > +++ b/drivers/gpu/host1x/Kconfig > @@ -3,4 +3,27 @@ config TEGRA_HOST1X > help >

[PATCHv5,RESEND 3/8] gpu: host1x: Add channel support

2013-01-15 Thread Terje Bergstrom
Add support for host1x client modules, and host1x channels to submit work to the clients. The work is submitted in GEM CMA buffers, so this patch adds support for them. Signed-off-by: Terje Bergstrom --- drivers/gpu/host1x/Kconfig | 25 +- drivers/gpu/host1x/Makefile