[PATCHv5,RESEND 2/8] gpu: host1x: Add syncpoint wait and interrupts

2013-02-06 Thread Thierry Reding
On Wed, Feb 06, 2013 at 12:29:26PM -0800, Terje Bergstr?m wrote: > On 05.02.2013 00:42, Thierry Reding wrote: [...] > > Or if that doesn't work it would still be preferable to allocate memory > > in host1x_syncpt_wait() directly instead of going through the wrapper. > > This was done purely, becau

Re: [PATCHv5, RESEND 2/8] gpu: host1x: Add syncpoint wait and interrupts

2013-02-06 Thread Terje Bergström
On 06.02.2013 12:38, Thierry Reding wrote: > On Wed, Feb 06, 2013 at 12:29:26PM -0800, Terje Bergström wrote: >> This was done purely, because I'm hiding the struct size from the >> caller. If the caller needs to allocate, I need to expose the struct in >> a header, not just a forward declaration.

[PATCHv5, RESEND 2/8] gpu: host1x: Add syncpoint wait and interrupts

2013-02-06 Thread Terje Bergström
On 06.02.2013 12:38, Thierry Reding wrote: > On Wed, Feb 06, 2013 at 12:29:26PM -0800, Terje Bergstr?m wrote: >> This was done purely, because I'm hiding the struct size from the >> caller. If the caller needs to allocate, I need to expose the struct in >> a header, not just a forward declaration.

Re: [PATCHv5,RESEND 2/8] gpu: host1x: Add syncpoint wait and interrupts

2013-02-06 Thread Thierry Reding
On Wed, Feb 06, 2013 at 12:29:26PM -0800, Terje Bergström wrote: > On 05.02.2013 00:42, Thierry Reding wrote: [...] > > Or if that doesn't work it would still be preferable to allocate memory > > in host1x_syncpt_wait() directly instead of going through the wrapper. > > This was done purely, becau

Re: [PATCHv5, RESEND 2/8] gpu: host1x: Add syncpoint wait and interrupts

2013-02-06 Thread Terje Bergström
On 05.02.2013 00:42, Thierry Reding wrote: > On Mon, Feb 04, 2013 at 08:29:08PM -0800, Terje Bergström wrote: >> host1x_get_host() actually needs that, so this #include should've also >> been in previous patch. > > No need to if you pass struct device * instead. You might need > linux/device.h ins

[PATCHv5, RESEND 2/8] gpu: host1x: Add syncpoint wait and interrupts

2013-02-06 Thread Terje Bergström
On 05.02.2013 00:42, Thierry Reding wrote: > On Mon, Feb 04, 2013 at 08:29:08PM -0800, Terje Bergstr?m wrote: >> host1x_get_host() actually needs that, so this #include should've also >> been in previous patch. > > No need to if you pass struct device * instead. You might need > linux/device.h ins

[PATCHv5,RESEND 2/8] gpu: host1x: Add syncpoint wait and interrupts

2013-02-05 Thread Thierry Reding
On Mon, Feb 04, 2013 at 08:29:08PM -0800, Terje Bergstr?m wrote: > On 04.02.2013 02:30, Thierry Reding wrote: > >> diff --git a/drivers/gpu/host1x/dev.h b/drivers/gpu/host1x/dev.h > >> index d8f5979..8376092 100644 > >> --- a/drivers/gpu/host1x/dev.h > >> +++ b/drivers/gpu/host1x/dev.h > >> @@ -17,

Re: [PATCHv5,RESEND 2/8] gpu: host1x: Add syncpoint wait and interrupts

2013-02-05 Thread Thierry Reding
On Mon, Feb 04, 2013 at 08:29:08PM -0800, Terje Bergström wrote: > On 04.02.2013 02:30, Thierry Reding wrote: > >> diff --git a/drivers/gpu/host1x/dev.h b/drivers/gpu/host1x/dev.h > >> index d8f5979..8376092 100644 > >> --- a/drivers/gpu/host1x/dev.h > >> +++ b/drivers/gpu/host1x/dev.h > >> @@ -17,

Re: [PATCHv5, RESEND 2/8] gpu: host1x: Add syncpoint wait and interrupts

2013-02-04 Thread Terje Bergström
On 04.02.2013 02:30, Thierry Reding wrote: > On Tue, Jan 15, 2013 at 01:43:58PM +0200, Terje Bergstrom wrote: > [...] >> diff --git a/drivers/gpu/host1x/dev.c b/drivers/gpu/host1x/dev.c > [...] >> @@ -95,7 +96,6 @@ static int host1x_probe(struct platform_device *dev) >> >> /* set common host1

[PATCHv5, RESEND 2/8] gpu: host1x: Add syncpoint wait and interrupts

2013-02-04 Thread Terje Bergström
On 04.02.2013 02:30, Thierry Reding wrote: > On Tue, Jan 15, 2013 at 01:43:58PM +0200, Terje Bergstrom wrote: > [...] >> diff --git a/drivers/gpu/host1x/dev.c b/drivers/gpu/host1x/dev.c > [...] >> @@ -95,7 +96,6 @@ static int host1x_probe(struct platform_device *dev) >> >> /* set common host1

[PATCHv5,RESEND 2/8] gpu: host1x: Add syncpoint wait and interrupts

2013-02-04 Thread Thierry Reding
On Tue, Jan 15, 2013 at 01:43:58PM +0200, Terje Bergstrom wrote: [...] > diff --git a/drivers/gpu/host1x/dev.c b/drivers/gpu/host1x/dev.c [...] > @@ -95,7 +96,6 @@ static int host1x_probe(struct platform_device *dev) > > /* set common host1x device data */ > platform_set_drvdata(dev,

Re: [PATCHv5,RESEND 2/8] gpu: host1x: Add syncpoint wait and interrupts

2013-02-04 Thread Thierry Reding
On Tue, Jan 15, 2013 at 01:43:58PM +0200, Terje Bergstrom wrote: [...] > diff --git a/drivers/gpu/host1x/dev.c b/drivers/gpu/host1x/dev.c [...] > @@ -95,7 +96,6 @@ static int host1x_probe(struct platform_device *dev) > > /* set common host1x device data */ > platform_set_drvdata(dev,

[PATCHv5,RESEND 2/8] gpu: host1x: Add syncpoint wait and interrupts

2013-01-15 Thread Terje Bergstrom
Add support for sync point interrupts, and sync point wait. Sync point wait used interrupts for unblocking wait. Signed-off-by: Terje Bergstrom --- drivers/gpu/host1x/Makefile |1 + drivers/gpu/host1x/dev.c | 21 +- drivers/gpu/host1x/dev.h |

[PATCHv5,RESEND 2/8] gpu: host1x: Add syncpoint wait and interrupts

2013-01-15 Thread Terje Bergstrom
Add support for sync point interrupts, and sync point wait. Sync point wait used interrupts for unblocking wait. Signed-off-by: Terje Bergstrom --- drivers/gpu/host1x/Makefile |1 + drivers/gpu/host1x/dev.c | 21 +- drivers/gpu/host1x/dev.h |