Re: [PATCHv4 4/6] drm/omap: fix incorrect union usage

2018-11-16 Thread Sebastian Reichel
Hi Tomi, On Fri, Nov 16, 2018 at 03:41:24PM +0200, Tomi Valkeinen wrote: > On 16/11/18 01:06, Sebastian Reichel wrote: > > The DSI encoder sets dssdev->ops->dsi.set_config, which is stored at the > > same offset as dssdev->ops->hdmi.set_hdmi_mode. The code in omap_encoder > > only checks if dssdev

Re: [PATCHv4 4/6] drm/omap: fix incorrect union usage

2018-11-16 Thread Tomi Valkeinen
On 16/11/18 01:06, Sebastian Reichel wrote: > The DSI encoder sets dssdev->ops->dsi.set_config, which is stored at the > same offset as dssdev->ops->hdmi.set_hdmi_mode. The code in omap_encoder > only checks if dssdev->ops->hdmi.set_hdmi_mode is NULL. Due to the way > union works, it won't be NULL

[PATCHv4 4/6] drm/omap: fix incorrect union usage

2018-11-16 Thread Sebastian Reichel
The DSI encoder sets dssdev->ops->dsi.set_config, which is stored at the same offset as dssdev->ops->hdmi.set_hdmi_mode. The code in omap_encoder only checks if dssdev->ops->hdmi.set_hdmi_mode is NULL. Due to the way union works, it won't be NULL if dsi.set_config is set. This means dsi_set_config