[PATCHv4 3/8] gpu: host1x: Add channel support

2013-01-02 Thread Mark Zhang
On 01/02/2013 05:31 PM, Terje Bergstr?m wrote: > On 02.01.2013 09:40, Mark Zhang wrote: >> On 12/21/2012 07:39 PM, Terje Bergstrom wrote: >>> Add support for host1x client modules, and host1x channels to submit >>> work to the clients. The work is submitted in GEM CMA buffers, so >>> this patch add

[PATCHv4 3/8] gpu: host1x: Add channel support

2013-01-02 Thread Mark Zhang
Just one minor issue. Check below. On 12/21/2012 07:39 PM, Terje Bergstrom wrote: > Add support for host1x client modules, and host1x channels to submit > work to the clients. The work is submitted in GEM CMA buffers, so > this patch adds support for them. > > Signed-off-by: Terje Bergstrom > --

[PATCHv4 3/8] gpu: host1x: Add channel support

2013-01-02 Thread Terje Bergström
On 02.01.2013 11:31, Mark Zhang wrote: > On 01/02/2013 05:31 PM, Terje Bergstr?m wrote: >> That's intentional. Writing a job to channel is atomic, so lock is taken >> from host1x_cdma_begin() until host1x_cdma_end(). >> > > Okay. So can we consider that lock and unlock this mutex in the function >

[PATCHv4 3/8] gpu: host1x: Add channel support

2013-01-02 Thread Terje Bergström
On 02.01.2013 09:40, Mark Zhang wrote: > On 12/21/2012 07:39 PM, Terje Bergstrom wrote: >> Add support for host1x client modules, and host1x channels to submit >> work to the clients. The work is submitted in GEM CMA buffers, so >> this patch adds support for them. >> >> Signed-off-by: Terje Bergst

[PATCHv4 3/8] gpu: host1x: Add channel support

2013-01-02 Thread Terje Bergström
On 22.12.2012 06:17, Steven Rostedt wrote: > On Fri, 2012-12-21 at 13:39 +0200, Terje Bergstrom wrote: >> +TRACE_EVENT(host1x_cdma_begin, >> +TP_PROTO(const char *name), >> + >> +TP_ARGS(name), >> + >> +TP_STRUCT__entry( >> +__field(const char *, name) >> +), >> + >> +

Re: [PATCHv4 3/8] gpu: host1x: Add channel support

2013-01-02 Thread Terje Bergström
On 02.01.2013 11:31, Mark Zhang wrote: > On 01/02/2013 05:31 PM, Terje Bergström wrote: >> That's intentional. Writing a job to channel is atomic, so lock is taken >> from host1x_cdma_begin() until host1x_cdma_end(). >> > > Okay. So can we consider that lock and unlock this mutex in the function >

Re: [PATCHv4 3/8] gpu: host1x: Add channel support

2013-01-02 Thread Mark Zhang
On 01/02/2013 05:31 PM, Terje Bergström wrote: > On 02.01.2013 09:40, Mark Zhang wrote: >> On 12/21/2012 07:39 PM, Terje Bergstrom wrote: >>> Add support for host1x client modules, and host1x channels to submit >>> work to the clients. The work is submitted in GEM CMA buffers, so >>> this patch add

Re: [PATCHv4 3/8] gpu: host1x: Add channel support

2013-01-02 Thread Terje Bergström
On 02.01.2013 09:40, Mark Zhang wrote: > On 12/21/2012 07:39 PM, Terje Bergstrom wrote: >> Add support for host1x client modules, and host1x channels to submit >> work to the clients. The work is submitted in GEM CMA buffers, so >> this patch adds support for them. >> >> Signed-off-by: Terje Bergst

Re: [PATCHv4 3/8] gpu: host1x: Add channel support

2013-01-02 Thread Terje Bergström
On 22.12.2012 06:17, Steven Rostedt wrote: > On Fri, 2012-12-21 at 13:39 +0200, Terje Bergstrom wrote: >> +TRACE_EVENT(host1x_cdma_begin, >> +TP_PROTO(const char *name), >> + >> +TP_ARGS(name), >> + >> +TP_STRUCT__entry( >> +__field(const char *, name) >> +), >> + >> +

Re: [PATCHv4 3/8] gpu: host1x: Add channel support

2013-01-01 Thread Mark Zhang
Just one minor issue. Check below. On 12/21/2012 07:39 PM, Terje Bergstrom wrote: > Add support for host1x client modules, and host1x channels to submit > work to the clients. The work is submitted in GEM CMA buffers, so > this patch adds support for them. > > Signed-off-by: Terje Bergstrom > --

Re: [PATCHv4 3/8] gpu: host1x: Add channel support

2012-12-22 Thread Steven Rostedt
On Fri, 2012-12-21 at 13:39 +0200, Terje Bergstrom wrote: > diff --git a/include/trace/events/host1x.h b/include/trace/events/host1x.h > index d98d74c..e087910 100644 > --- a/include/trace/events/host1x.h > +++ b/include/trace/events/host1x.h > @@ -37,6 +37,214 @@ DECLARE_EVENT_CLASS(host1x, >

[PATCHv4 3/8] gpu: host1x: Add channel support

2012-12-21 Thread Steven Rostedt
On Fri, 2012-12-21 at 13:39 +0200, Terje Bergstrom wrote: > diff --git a/include/trace/events/host1x.h b/include/trace/events/host1x.h > index d98d74c..e087910 100644 > --- a/include/trace/events/host1x.h > +++ b/include/trace/events/host1x.h > @@ -37,6 +37,214 @@ DECLARE_EVENT_CLASS(host1x, >

[PATCHv4 3/8] gpu: host1x: Add channel support

2012-12-21 Thread Terje Bergstrom
Add support for host1x client modules, and host1x channels to submit work to the clients. The work is submitted in GEM CMA buffers, so this patch adds support for them. Signed-off-by: Terje Bergstrom --- drivers/gpu/host1x/Kconfig | 24 +- drivers/gpu/host1x/Makefile