RE: [PATCHv3 1/6] drm/i915/histogram: Add support for histogram

2024-09-25 Thread Murthy, Arun R
> > > +static int intel_histogram_enable(struct intel_crtc *intel_crtc) { > > > + struct intel_display *display = to_intel_display(intel_crtc); > > > + struct intel_histogram *histogram = intel_crtc->histogram; > > > + int pipe = intel_crtc->pipe; > > > + u64 res; > > > + u32 gbandthreshold; > > >

RE: [PATCHv3 1/6] drm/i915/histogram: Add support for histogram

2024-09-24 Thread Kandpal, Suraj
y, Arun R > Subject: RE: [PATCHv3 1/6] drm/i915/histogram: Add support for histogram > > > > > -Original Message- > > From: Intel-gfx On Behalf Of > > Arun R Murthy > > Sent: Thursday, September 19, 2024 7:02 PM > > To: intel...@l

RE: [PATCHv3 1/6] drm/i915/histogram: Add support for histogram

2024-09-24 Thread Murthy, Arun R
> > +struct intel_histogram { > > + struct intel_crtc *crtc; > > + struct delayed_work histogram_int_work; > > I think I mentioned this in my previous comment but naming this just work > should be fine since I don’t see any other work for histogram So itll be > called as > histogram->work whi

RE: [PATCHv3 1/6] drm/i915/histogram: Add support for histogram

2024-09-24 Thread Kandpal, Suraj
> -Original Message- > From: Intel-gfx On Behalf Of Arun > R Murthy > Sent: Thursday, September 19, 2024 7:02 PM > To: intel...@lists.freedesktop.org; intel-...@lists.freedesktop.org; dri- > de...@lists.freedesktop.org > Cc: Murthy, Arun R > Subject: [PATCHv3

[PATCHv3 1/6] drm/i915/histogram: Add support for histogram

2024-09-19 Thread Arun R Murthy
Statistics is generated from the image frame that is coming to display and an event is sent to user after reading this histogram data. This statistics/histogram is then shared with the user upon getting a request from user. User can then use this histogram and generate an enhancement factor. This e