Re: [PATCHv3 02/11] drm/i915/gem: Convert __shmem_writeback() to folios

2025-01-31 Thread Shakeel Butt
On Thu, Jan 30, 2025 at 12:00:40PM +0200, Kirill A. Shutemov wrote: > Use folios instead of pages. > > This is preparation for removing PG_reclaim. > > Signed-off-by: Kirill A. Shutemov > Acked-by: David Hildenbrand > --- > drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 18 +- > 1

Re: [PATCHv3 02/11] drm/i915/gem: Convert __shmem_writeback() to folios

2025-01-31 Thread Matthew Wilcox
On Thu, Jan 30, 2025 at 12:00:40PM +0200, Kirill A. Shutemov wrote: > Use folios instead of pages. > > This is preparation for removing PG_reclaim. Well, this is a horrid little function. Rather than iterating just the dirty folios, it iterates all folios, then locks them before checking whether

Re: [PATCHv3 02/11] drm/i915/gem: Convert __shmem_writeback() to folios

2025-01-31 Thread Andi Shyti
Hi Kirill, On Thu, Jan 30, 2025 at 12:00:40PM +0200, Kirill A. Shutemov wrote: > Use folios instead of pages. > > This is preparation for removing PG_reclaim. > > Signed-off-by: Kirill A. Shutemov > Acked-by: David Hildenbrand looks good: Reviewed-by: Andi Shyti Thanks, Andi