Re: [PATCHv2 31/31] drm/omap: fix crash on module unload

2017-03-26 Thread Tomi Valkeinen
On 25/03/17 23:25, Daniel Vetter wrote: > On Fri, Mar 24, 2017 at 11:40:52AM +0200, Tomi Valkeinen wrote: >> When unloading omapdrm we get a NULL pointer deref in >> omap_drm_irq_uninstall(). This is caused by: >> >> 967dd48417874dd25491a4e933648f394a64f70f ("drm: remove >> drm_vblank_no_hw_counter

Re: [PATCHv2 31/31] drm/omap: fix crash on module unload

2017-03-25 Thread Daniel Vetter
On Fri, Mar 24, 2017 at 11:40:52AM +0200, Tomi Valkeinen wrote: > When unloading omapdrm we get a NULL pointer deref in > omap_drm_irq_uninstall(). This is caused by: > > 967dd48417874dd25491a4e933648f394a64f70f ("drm: remove > drm_vblank_no_hw_counter assignment from driver code") > > As OMAP DS

[PATCHv2 31/31] drm/omap: fix crash on module unload

2017-03-24 Thread Tomi Valkeinen
When unloading omapdrm we get a NULL pointer deref in omap_drm_irq_uninstall(). This is caused by: 967dd48417874dd25491a4e933648f394a64f70f ("drm: remove drm_vblank_no_hw_counter assignment from driver code") As OMAP DSS does not have a HW vblank counter, vblank[i].last is anyway always 0, so we