[PATCHv2 3/9] v4l: add buffer exporting via dmabuf

2012-08-08 Thread Sakari Ailus
Hi Hans and R?mi, On Thu, Aug 02, 2012 at 08:35:58AM +0200, Hans Verkuil wrote: ... > Minimum or maximum? The maximum is 32, that's hardcoded in the V4L2 core. As far as I understand, V4L1 did have that limitation, as well as videobuf1 and 2 and a number of other drivers, but it's not found in th

[PATCHv2 3/9] v4l: add buffer exporting via dmabuf

2012-08-08 Thread Hans Verkuil
On Wed 8 August 2012 11:35:38 Sakari Ailus wrote: > Hi Hans and R?mi, > > On Thu, Aug 02, 2012 at 08:35:58AM +0200, Hans Verkuil wrote: > ... > > Minimum or maximum? The maximum is 32, that's hardcoded in the V4L2 core. > > As far as I understand, V4L1 did have that limitation, as well as videobu

Re: [PATCHv2 3/9] v4l: add buffer exporting via dmabuf

2012-08-08 Thread Sakari Ailus
Hi Hans and Rémi, On Thu, Aug 02, 2012 at 08:35:58AM +0200, Hans Verkuil wrote: ... > Minimum or maximum? The maximum is 32, that's hardcoded in the V4L2 core. As far as I understand, V4L1 did have that limitation, as well as videobuf1 and 2 and a number of other drivers, but it's not found in th

Re: [PATCHv2 3/9] v4l: add buffer exporting via dmabuf

2012-08-08 Thread Hans Verkuil
On Wed 8 August 2012 11:35:38 Sakari Ailus wrote: > Hi Hans and Rémi, > > On Thu, Aug 02, 2012 at 08:35:58AM +0200, Hans Verkuil wrote: > ... > > Minimum or maximum? The maximum is 32, that's hardcoded in the V4L2 core. > > As far as I understand, V4L1 did have that limitation, as well as videobu

[PATCHv2 3/9] v4l: add buffer exporting via dmabuf

2012-08-02 Thread Laurent Pinchart
Hi Hans, On Thursday 02 August 2012 09:08:18 Hans Verkuil wrote: > On Thu August 2 2012 08:56:43 R?mi Denis-Courmont wrote: > > Le jeudi 2 ao?t 2012 09:35:58 Hans Verkuil, vous avez ?crit : > > > On Wed August 1 2012 22:49:57 R?mi Denis-Courmont wrote: > > > > > What about using the CREATE_BUFS io

[PATCHv2 3/9] v4l: add buffer exporting via dmabuf

2012-08-02 Thread Laurent Pinchart
Hi R?mi, On Thursday 02 August 2012 09:56:43 R?mi Denis-Courmont wrote: > Le jeudi 2 ao?t 2012 09:35:58 Hans Verkuil, vous avez ?crit : > > On Wed August 1 2012 22:49:57 R?mi Denis-Courmont wrote: > > > > What about using the CREATE_BUFS ioctl to add new MMAP buffers at > > > > runtime ? > > > >

Re: [PATCHv2 3/9] v4l: add buffer exporting via dmabuf

2012-08-02 Thread Rémi Denis-Courmont
Le jeudi 2 août 2012 09:35:58 Hans Verkuil, vous avez écrit : > On Wed August 1 2012 22:49:57 Rémi Denis-Courmont wrote: > > > What about using the CREATE_BUFS ioctl to add new MMAP buffers at > > > runtime ? > > > > Does CREATE_BUFS always work while already streaming has already started? > > If

Re: [PATCHv2 3/9] v4l: add buffer exporting via dmabuf

2012-08-02 Thread Laurent Pinchart
Hi Hans, On Thursday 02 August 2012 09:08:18 Hans Verkuil wrote: > On Thu August 2 2012 08:56:43 Rémi Denis-Courmont wrote: > > Le jeudi 2 août 2012 09:35:58 Hans Verkuil, vous avez écrit : > > > On Wed August 1 2012 22:49:57 Rémi Denis-Courmont wrote: > > > > > What about using the CREATE_BUFS io

Re: [PATCHv2 3/9] v4l: add buffer exporting via dmabuf

2012-08-02 Thread Laurent Pinchart
Hi Rémi, On Thursday 02 August 2012 09:56:43 Rémi Denis-Courmont wrote: > Le jeudi 2 août 2012 09:35:58 Hans Verkuil, vous avez écrit : > > On Wed August 1 2012 22:49:57 Rémi Denis-Courmont wrote: > > > > What about using the CREATE_BUFS ioctl to add new MMAP buffers at > > > > runtime ? > > > >

[PATCHv2 3/9] v4l: add buffer exporting via dmabuf

2012-08-02 Thread Rémi Denis-Courmont
Le jeudi 2 ao?t 2012 09:35:58 Hans Verkuil, vous avez ?crit : > On Wed August 1 2012 22:49:57 R?mi Denis-Courmont wrote: > > > What about using the CREATE_BUFS ioctl to add new MMAP buffers at > > > runtime ? > > > > Does CREATE_BUFS always work while already streaming has already started? > > If

[PATCHv2 3/9] v4l: add buffer exporting via dmabuf

2012-08-02 Thread Hans Verkuil
On Thu August 2 2012 08:56:43 R?mi Denis-Courmont wrote: > Le jeudi 2 ao?t 2012 09:35:58 Hans Verkuil, vous avez ?crit : > > On Wed August 1 2012 22:49:57 R?mi Denis-Courmont wrote: > > > > What about using the CREATE_BUFS ioctl to add new MMAP buffers at > > > > runtime ? > > > > > > Does CREATE_

[PATCHv2 3/9] v4l: add buffer exporting via dmabuf

2012-08-02 Thread Hans Verkuil
On Wed August 1 2012 22:49:57 R?mi Denis-Courmont wrote: > Le mercredi 1 ao?t 2012 14:35:03 Laurent Pinchart, vous avez ?crit : > > > But in general, the V4L element in the pipeline does not know how fast > > > the downstream element(s) will consume the buffers. Thus it has to copy > > > from the M

Re: [PATCHv2 3/9] v4l: add buffer exporting via dmabuf

2012-08-02 Thread Hans Verkuil
On Thu August 2 2012 08:56:43 Rémi Denis-Courmont wrote: > Le jeudi 2 août 2012 09:35:58 Hans Verkuil, vous avez écrit : > > On Wed August 1 2012 22:49:57 Rémi Denis-Courmont wrote: > > > > What about using the CREATE_BUFS ioctl to add new MMAP buffers at > > > > runtime ? > > > > > > Does CREATE_

Re: [PATCHv2 3/9] v4l: add buffer exporting via dmabuf

2012-08-02 Thread Hans Verkuil
On Wed August 1 2012 22:49:57 Rémi Denis-Courmont wrote: > Le mercredi 1 août 2012 14:35:03 Laurent Pinchart, vous avez écrit : > > > But in general, the V4L element in the pipeline does not know how fast > > > the downstream element(s) will consume the buffers. Thus it has to copy > > > from the M

[PATCHv2 3/9] v4l: add buffer exporting via dmabuf

2012-08-01 Thread Rémi Denis-Courmont
Le mercredi 1 ao?t 2012 14:35:03 Laurent Pinchart, vous avez ?crit : > > But in general, the V4L element in the pipeline does not know how fast > > the downstream element(s) will consume the buffers. Thus it has to copy > > from the MMAP buffers into anonymous user memory pending processing. > > Th

Re: [PATCHv2 3/9] v4l: add buffer exporting via dmabuf

2012-08-01 Thread Rémi Denis-Courmont
Le mercredi 1 août 2012 14:35:03 Laurent Pinchart, vous avez écrit : > > But in general, the V4L element in the pipeline does not know how fast > > the downstream element(s) will consume the buffers. Thus it has to copy > > from the MMAP buffers into anonymous user memory pending processing. > > Th

[PATCHv2 3/9] v4l: add buffer exporting via dmabuf

2012-08-01 Thread Laurent Pinchart
Hi R?mi, On Wednesday 01 August 2012 10:37:02 R?mi Denis-Courmont wrote: > On Tue, 31 Jul 2012 23:52:35 +0200, Laurent Pinchart wrote: > >> I want to receive the video buffers in user space for processing. > >> Typically "processing" is software encoding or conversion. That's what > >> virtually a

[PATCHv2 3/9] v4l: add buffer exporting via dmabuf

2012-08-01 Thread Tomasz Stanislawski
Hi Hans, >> >> I do not see any good point in using v4l2_plane. What would be the meaning >> of bytesused, length, data_offset in case of DMABUF exporting? >> >> The field reserved0 was introduced to be replaced by __u32 memory if other >> means >> of buffer description would be needed. The reser

[PATCHv2 3/9] v4l: add buffer exporting via dmabuf

2012-08-01 Thread Rémi Denis-Courmont
On Tue, 31 Jul 2012 23:52:35 +0200, Laurent Pinchart wrote: >> I want to receive the video buffers in user space for processing. >> Typically >> "processing" is software encoding or conversion. That's what virtually >> any >> V4L application does on the desktop... > > But what prevents you from u

[PATCHv2 3/9] v4l: add buffer exporting via dmabuf

2012-08-01 Thread Hans Verkuil
On Wed 1 August 2012 10:01:45 Tomasz Stanislawski wrote: > Hi Hans, > > On 07/31/2012 02:11 PM, Hans Verkuil wrote: > > On Tue 31 July 2012 13:56:14 Laurent Pinchart wrote: > >> Hi Hans, > >> > >> On Tuesday 31 July 2012 08:33:56 Hans Verkuil wrote: > >>> On Thu June 14 2012 16:32:23 Tomasz Stanis

[PATCHv2 3/9] v4l: add buffer exporting via dmabuf

2012-08-01 Thread Laurent Pinchart
Hi Tomasz, On Wednesday 01 August 2012 10:01:45 Tomasz Stanislawski wrote: > On 07/31/2012 02:11 PM, Hans Verkuil wrote: > > On Tue 31 July 2012 13:56:14 Laurent Pinchart wrote: > >> On Tuesday 31 July 2012 08:33:56 Hans Verkuil wrote: > >>> On Thu June 14 2012 16:32:23 Tomasz Stanislawski wrote:

[PATCHv2 3/9] v4l: add buffer exporting via dmabuf

2012-08-01 Thread Tomasz Stanislawski
Hi Hans, On 07/31/2012 02:11 PM, Hans Verkuil wrote: > On Tue 31 July 2012 13:56:14 Laurent Pinchart wrote: >> Hi Hans, >> >> On Tuesday 31 July 2012 08:33:56 Hans Verkuil wrote: >>> On Thu June 14 2012 16:32:23 Tomasz Stanislawski wrote: +/** + * struct v4l2_exportbuffer - export of vid

Re: [PATCHv2 3/9] v4l: add buffer exporting via dmabuf

2012-08-01 Thread Laurent Pinchart
Hi Rémi, On Wednesday 01 August 2012 10:37:02 Rémi Denis-Courmont wrote: > On Tue, 31 Jul 2012 23:52:35 +0200, Laurent Pinchart wrote: > >> I want to receive the video buffers in user space for processing. > >> Typically "processing" is software encoding or conversion. That's what > >> virtually a

Re: [PATCHv2 3/9] v4l: add buffer exporting via dmabuf

2012-08-01 Thread Tomasz Stanislawski
Hi Hans, >> >> I do not see any good point in using v4l2_plane. What would be the meaning >> of bytesused, length, data_offset in case of DMABUF exporting? >> >> The field reserved0 was introduced to be replaced by __u32 memory if other >> means >> of buffer description would be needed. The reser

Re: [PATCHv2 3/9] v4l: add buffer exporting via dmabuf

2012-08-01 Thread Rémi Denis-Courmont
On Tue, 31 Jul 2012 23:52:35 +0200, Laurent Pinchart wrote: >> I want to receive the video buffers in user space for processing. >> Typically >> "processing" is software encoding or conversion. That's what virtually >> any >> V4L application does on the desktop... > > But what prevents you from u

Re: [PATCHv2 3/9] v4l: add buffer exporting via dmabuf

2012-08-01 Thread Rémi Denis-Courmont
Le mardi 31 juillet 2012 19:28:12 Laurent Pinchart, vous avez écrit : > Hi Rémi, > > On Tuesday 31 July 2012 16:39:00 Rémi Denis-Courmont wrote: > > Le mardi 31 juillet 2012 14:56:14 Laurent Pinchart, vous avez écrit : > > > > For that matter, wouldn't it be useful to support exporting a userptr >

Re: [PATCHv2 3/9] v4l: add buffer exporting via dmabuf

2012-08-01 Thread Rémi Denis-Courmont
Le mardi 31 juillet 2012 17:03:52 Rob Clark, vous avez écrit : > On Tue, Jul 31, 2012 at 8:39 AM, Rémi Denis-Courmont wrote: > > Le mardi 31 juillet 2012 14:56:14 Laurent Pinchart, vous avez écrit : > >> > For that matter, wouldn't it be useful to support exporting a userptr > >> > buffer at some

Re: [PATCHv2 3/9] v4l: add buffer exporting via dmabuf

2012-08-01 Thread Rémi Denis-Courmont
Le mardi 31 juillet 2012 14:56:14 Laurent Pinchart, vous avez écrit : > > For that matter, wouldn't it be useful to support exporting a userptr > > buffer at some point in the future? > > Shouldn't USERPTR usage be discouraged once we get dma-buf support ? USERPTR, where available, is currently t

Re: [PATCHv2 3/9] v4l: add buffer exporting via dmabuf

2012-08-01 Thread Hans Verkuil
On Wed 1 August 2012 10:01:45 Tomasz Stanislawski wrote: > Hi Hans, > > On 07/31/2012 02:11 PM, Hans Verkuil wrote: > > On Tue 31 July 2012 13:56:14 Laurent Pinchart wrote: > >> Hi Hans, > >> > >> On Tuesday 31 July 2012 08:33:56 Hans Verkuil wrote: > >>> On Thu June 14 2012 16:32:23 Tomasz Stanis

Re: [PATCHv2 3/9] v4l: add buffer exporting via dmabuf

2012-08-01 Thread Tomasz Stanislawski
Hi Hans, On 07/31/2012 02:11 PM, Hans Verkuil wrote: > On Tue 31 July 2012 13:56:14 Laurent Pinchart wrote: >> Hi Hans, >> >> On Tuesday 31 July 2012 08:33:56 Hans Verkuil wrote: >>> On Thu June 14 2012 16:32:23 Tomasz Stanislawski wrote: +/** + * struct v4l2_exportbuffer - export of vid

Re: [PATCHv2 3/9] v4l: add buffer exporting via dmabuf

2012-08-01 Thread Laurent Pinchart
Hi Tomasz, On Wednesday 01 August 2012 10:01:45 Tomasz Stanislawski wrote: > On 07/31/2012 02:11 PM, Hans Verkuil wrote: > > On Tue 31 July 2012 13:56:14 Laurent Pinchart wrote: > >> On Tuesday 31 July 2012 08:33:56 Hans Verkuil wrote: > >>> On Thu June 14 2012 16:32:23 Tomasz Stanislawski wrote:

[PATCHv2 3/9] v4l: add buffer exporting via dmabuf

2012-07-31 Thread Laurent Pinchart
Hi R?mi, On Tuesday 31 July 2012 21:39:40 R?mi Denis-Courmont wrote: > Le mardi 31 juillet 2012 19:28:12 Laurent Pinchart, vous avez ?crit : > > On Tuesday 31 July 2012 16:39:00 R?mi Denis-Courmont wrote: > > > Le mardi 31 juillet 2012 14:56:14 Laurent Pinchart, vous avez ?crit : > > > > > For tha

[PATCHv2 3/9] v4l: add buffer exporting via dmabuf

2012-07-31 Thread Rémi Denis-Courmont
Le mardi 31 juillet 2012 19:28:12 Laurent Pinchart, vous avez ?crit : > Hi R?mi, > > On Tuesday 31 July 2012 16:39:00 R?mi Denis-Courmont wrote: > > Le mardi 31 juillet 2012 14:56:14 Laurent Pinchart, vous avez ?crit : > > > > For that matter, wouldn't it be useful to support exporting a userptr >

[PATCHv2 3/9] v4l: add buffer exporting via dmabuf

2012-07-31 Thread Laurent Pinchart
Hi R?mi, On Tuesday 31 July 2012 16:39:00 R?mi Denis-Courmont wrote: > Le mardi 31 juillet 2012 14:56:14 Laurent Pinchart, vous avez ?crit : > > > For that matter, wouldn't it be useful to support exporting a userptr > > > buffer at some point in the future? > > > > Shouldn't USERPTR usage be dis

[PATCHv2 3/9] v4l: add buffer exporting via dmabuf

2012-07-31 Thread Rémi Denis-Courmont
Le mardi 31 juillet 2012 17:03:52 Rob Clark, vous avez ?crit : > On Tue, Jul 31, 2012 at 8:39 AM, R?mi Denis-Courmont wrote: > > Le mardi 31 juillet 2012 14:56:14 Laurent Pinchart, vous avez ?crit : > >> > For that matter, wouldn't it be useful to support exporting a userptr > >> > buffer at some

[PATCHv2 3/9] v4l: add buffer exporting via dmabuf

2012-07-31 Thread Rémi Denis-Courmont
Le mardi 31 juillet 2012 14:56:14 Laurent Pinchart, vous avez ?crit : > > For that matter, wouldn't it be useful to support exporting a userptr > > buffer at some point in the future? > > Shouldn't USERPTR usage be discouraged once we get dma-buf support ? USERPTR, where available, is currently t

Re: [PATCHv2 3/9] v4l: add buffer exporting via dmabuf

2012-07-31 Thread Laurent Pinchart
Hi Rémi, On Tuesday 31 July 2012 21:39:40 Rémi Denis-Courmont wrote: > Le mardi 31 juillet 2012 19:28:12 Laurent Pinchart, vous avez écrit : > > On Tuesday 31 July 2012 16:39:00 Rémi Denis-Courmont wrote: > > > Le mardi 31 juillet 2012 14:56:14 Laurent Pinchart, vous avez écrit : > > > > > For tha

[PATCHv2 3/9] v4l: add buffer exporting via dmabuf

2012-07-31 Thread Hans Verkuil
On Tue 31 July 2012 13:56:14 Laurent Pinchart wrote: > Hi Hans, > > On Tuesday 31 July 2012 08:33:56 Hans Verkuil wrote: > > On Thu June 14 2012 16:32:23 Tomasz Stanislawski wrote: > > > +/** > > > + * struct v4l2_exportbuffer - export of video buffer as DMABUF file > > > descriptor + * > > > + *

[PATCHv2 3/9] v4l: add buffer exporting via dmabuf

2012-07-31 Thread Laurent Pinchart
Hi Hans, On Tuesday 31 July 2012 08:33:56 Hans Verkuil wrote: > On Thu June 14 2012 16:32:23 Tomasz Stanislawski wrote: > > This patch adds extension to V4L2 api. It allow to export a mmap buffer as > > file descriptor. New ioctl VIDIOC_EXPBUF is added. It takes a buffer > > offset used by mmap an

Re: [PATCHv2 3/9] v4l: add buffer exporting via dmabuf

2012-07-31 Thread Laurent Pinchart
Hi Rémi, On Tuesday 31 July 2012 16:39:00 Rémi Denis-Courmont wrote: > Le mardi 31 juillet 2012 14:56:14 Laurent Pinchart, vous avez écrit : > > > For that matter, wouldn't it be useful to support exporting a userptr > > > buffer at some point in the future? > > > > Shouldn't USERPTR usage be dis

[PATCHv2 3/9] v4l: add buffer exporting via dmabuf

2012-07-31 Thread Rob Clark
On Tue, Jul 31, 2012 at 8:39 AM, R?mi Denis-Courmont wrote: > Le mardi 31 juillet 2012 14:56:14 Laurent Pinchart, vous avez ?crit : >> > For that matter, wouldn't it be useful to support exporting a userptr >> > buffer at some point in the future? >> >> Shouldn't USERPTR usage be discouraged once

[PATCHv2 3/9] v4l: add buffer exporting via dmabuf

2012-07-31 Thread Hans Verkuil
On Thu June 14 2012 16:32:23 Tomasz Stanislawski wrote: > This patch adds extension to V4L2 api. It allow to export a mmap buffer as > file > descriptor. New ioctl VIDIOC_EXPBUF is added. It takes a buffer offset used by > mmap and return a file descriptor on success. > > Signed-off-by: Tomasz St

[PATCHv2 3/9] v4l: add buffer exporting via dmabuf

2012-07-31 Thread Rob Clark
On Tue, Jul 31, 2012 at 7:11 AM, Hans Verkuil wrote: >> > For that matter, wouldn't it be useful to support exporting a userptr >> > buffer >> > at some point in the future? >> >> Shouldn't USERPTR usage be discouraged once we get dma-buf support ? > > Why? It's perfectly fine to use it and it's

Re: [PATCHv2 3/9] v4l: add buffer exporting via dmabuf

2012-07-31 Thread Rob Clark
On Tue, Jul 31, 2012 at 8:39 AM, Rémi Denis-Courmont wrote: > Le mardi 31 juillet 2012 14:56:14 Laurent Pinchart, vous avez écrit : >> > For that matter, wouldn't it be useful to support exporting a userptr >> > buffer at some point in the future? >> >> Shouldn't USERPTR usage be discouraged once

Re: [PATCHv2 3/9] v4l: add buffer exporting via dmabuf

2012-07-31 Thread Rob Clark
On Tue, Jul 31, 2012 at 7:11 AM, Hans Verkuil wrote: >> > For that matter, wouldn't it be useful to support exporting a userptr >> > buffer >> > at some point in the future? >> >> Shouldn't USERPTR usage be discouraged once we get dma-buf support ? > > Why? It's perfectly fine to use it and it's

Re: [PATCHv2 3/9] v4l: add buffer exporting via dmabuf

2012-07-31 Thread Hans Verkuil
On Tue 31 July 2012 13:56:14 Laurent Pinchart wrote: > Hi Hans, > > On Tuesday 31 July 2012 08:33:56 Hans Verkuil wrote: > > On Thu June 14 2012 16:32:23 Tomasz Stanislawski wrote: > > > +/** > > > + * struct v4l2_exportbuffer - export of video buffer as DMABUF file > > > descriptor + * > > > + *

Re: [PATCHv2 3/9] v4l: add buffer exporting via dmabuf

2012-07-31 Thread Laurent Pinchart
Hi Hans, On Tuesday 31 July 2012 08:33:56 Hans Verkuil wrote: > On Thu June 14 2012 16:32:23 Tomasz Stanislawski wrote: > > This patch adds extension to V4L2 api. It allow to export a mmap buffer as > > file descriptor. New ioctl VIDIOC_EXPBUF is added. It takes a buffer > > offset used by mmap an

Re: [PATCHv2 3/9] v4l: add buffer exporting via dmabuf

2012-07-31 Thread Hans Verkuil
On Thu June 14 2012 16:32:23 Tomasz Stanislawski wrote: > This patch adds extension to V4L2 api. It allow to export a mmap buffer as > file > descriptor. New ioctl VIDIOC_EXPBUF is added. It takes a buffer offset used by > mmap and return a file descriptor on success. > > Signed-off-by: Tomasz St

[PATCHv2 3/9] v4l: add buffer exporting via dmabuf

2012-06-14 Thread Tomasz Stanislawski
This patch adds extension to V4L2 api. It allow to export a mmap buffer as file descriptor. New ioctl VIDIOC_EXPBUF is added. It takes a buffer offset used by mmap and return a file descriptor on success. Signed-off-by: Tomasz Stanislawski Signed-off-by: Kyungmin Park --- drivers/media/video/v4

[PATCHv2 3/9] v4l: add buffer exporting via dmabuf

2012-06-14 Thread Tomasz Stanislawski
This patch adds extension to V4L2 api. It allow to export a mmap buffer as file descriptor. New ioctl VIDIOC_EXPBUF is added. It takes a buffer offset used by mmap and return a file descriptor on success. Signed-off-by: Tomasz Stanislawski Signed-off-by: Kyungmin Park --- drivers/media/video/v4