[PATCHv2 2/2] drm/omap: fix primary-plane's possible_crtcs

2016-12-08 Thread Tomi Valkeinen
On 02/12/16 17:56, Laurent Pinchart wrote: > Hi Tomi, > > On Friday 02 Dec 2016 17:55:10 Tomi Valkeinen wrote: >> On 02/12/16 17:42, Laurent Pinchart wrote: >>> I can understand that (even if I'm not sure it's really an issue, and we >>> should really clean up the CRTC creation code at some point)

[PATCHv2 2/2] drm/omap: fix primary-plane's possible_crtcs

2016-12-02 Thread Laurent Pinchart
Hi Tomi, On Friday 02 Dec 2016 17:55:10 Tomi Valkeinen wrote: > On 02/12/16 17:42, Laurent Pinchart wrote: > > I can understand that (even if I'm not sure it's really an issue, and we > > should really clean up the CRTC creation code at some point), but how > > about adding a possible_crtcs field

[PATCHv2 2/2] drm/omap: fix primary-plane's possible_crtcs

2016-12-02 Thread Tomi Valkeinen
On 02/12/16 17:42, Laurent Pinchart wrote: > I can understand that (even if I'm not sure it's really an issue, and we > should really clean up the CRTC creation code at some point), but how about > adding a possible_crtcs field to the priv structure then ? I don't really > like > having to pas

[PATCHv2 2/2] drm/omap: fix primary-plane's possible_crtcs

2016-12-02 Thread Laurent Pinchart
Hi Tomi, On Friday 02 Dec 2016 16:22:18 Tomi Valkeinen wrote: > On 02/12/16 16:16, Laurent Pinchart wrote: > > On Friday 02 Dec 2016 16:07:11 Tomi Valkeinen wrote: > >> We set the possible_crtc for all planes to "(1 << priv->num_crtcs) - 1", > >> which is fine as the HW planes can be used fro all

[PATCHv2 2/2] drm/omap: fix primary-plane's possible_crtcs

2016-12-02 Thread Tomi Valkeinen
On 02/12/16 16:16, Laurent Pinchart wrote: > Hi Tomi, > > Thank you for the patch. > > On Friday 02 Dec 2016 16:07:11 Tomi Valkeinen wrote: >> We set the possible_crtc for all planes to "(1 << priv->num_crtcs) - 1", >> which is fine as the HW planes can be used fro all crtcs. However, when >> we'

[PATCHv2 2/2] drm/omap: fix primary-plane's possible_crtcs

2016-12-02 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Friday 02 Dec 2016 16:07:11 Tomi Valkeinen wrote: > We set the possible_crtc for all planes to "(1 << priv->num_crtcs) - 1", > which is fine as the HW planes can be used fro all crtcs. However, when > we're doing that, we are still incrementing 'num_crtcs', an

[PATCHv2 2/2] drm/omap: fix primary-plane's possible_crtcs

2016-12-02 Thread Tomi Valkeinen
We set the possible_crtc for all planes to "(1 << priv->num_crtcs) - 1", which is fine as the HW planes can be used fro all crtcs. However, when we're doing that, we are still incrementing 'num_crtcs', and we'll end up with bad possible_crtcs, preventing the use of the primary planes. This patch p