Re: [Intel-gfx] [PATCH v9 63/70] drm/i915: Move gt_revoke() slightly

2021-03-24 Thread Ville Syrjälä
On Wed, Mar 24, 2021 at 06:16:44PM +0100, Daniel Vetter wrote: > On Wed, Mar 24, 2021 at 07:15:36PM +0200, Ville Syrjälä wrote: > > On Wed, Mar 24, 2021 at 06:00:12PM +0100, Daniel Vetter wrote: > > > On Tue, Mar 23, 2021 at 04:50:52PM +0100, Maarten Lankhorst wrote: > > > > We get a lockdep splat

Re: [Intel-gfx] [PATCH v9 63/70] drm/i915: Move gt_revoke() slightly

2021-03-24 Thread Daniel Vetter
On Wed, Mar 24, 2021 at 07:15:36PM +0200, Ville Syrjälä wrote: > On Wed, Mar 24, 2021 at 06:00:12PM +0100, Daniel Vetter wrote: > > On Tue, Mar 23, 2021 at 04:50:52PM +0100, Maarten Lankhorst wrote: > > > We get a lockdep splat when the reset mutex is held, because it can be > > > taken from fence_

Re: [Intel-gfx] [PATCH v9 63/70] drm/i915: Move gt_revoke() slightly

2021-03-24 Thread Ville Syrjälä
On Wed, Mar 24, 2021 at 06:00:12PM +0100, Daniel Vetter wrote: > On Tue, Mar 23, 2021 at 04:50:52PM +0100, Maarten Lankhorst wrote: > > We get a lockdep splat when the reset mutex is held, because it can be > > taken from fence_wait. This conflicts with the mmu notifier we have, > > because we recu

Re: [Intel-gfx] [PATCH v9 63/70] drm/i915: Move gt_revoke() slightly

2021-03-24 Thread Daniel Vetter
On Tue, Mar 23, 2021 at 04:50:52PM +0100, Maarten Lankhorst wrote: > We get a lockdep splat when the reset mutex is held, because it can be > taken from fence_wait. This conflicts with the mmu notifier we have, > because we recurse between reset mutex and mmap lock -> mmu notifier. > > Remove this

[PATCH v9 63/70] drm/i915: Move gt_revoke() slightly

2021-03-23 Thread Maarten Lankhorst
We get a lockdep splat when the reset mutex is held, because it can be taken from fence_wait. This conflicts with the mmu notifier we have, because we recurse between reset mutex and mmap lock -> mmu notifier. Remove this recursion by calling revoke_mmaps before taking the lock. The reset code st