[PATCH v9 3/4] ASoC: tda998x: add a codec to the HDMI transmitter

2015-01-13 Thread Jean-Francois Moine
On Fri, 09 Jan 2015 17:39:08 + Andrew Jackson wrote: > > + snd_pcm_hw_constraint_minmax(runtime, > > + SNDRV_PCM_HW_PARAM_CHANNELS, > > + 1, sad[SAD_MX_CHAN_I]); > > In the light of our discussions elsewhere [1], shouldn't t

[PATCH v9 3/4] ASoC: tda998x: add a codec to the HDMI transmitter

2015-01-13 Thread Jean-Francois Moine
On Sun, 11 Jan 2015 23:03:14 +0200 Jyri Sarha wrote: > Some more comments based on my - finally successful - attempt to use > this code with BBB HDMI audio. > > On 01/07/2015 12:51 PM, Jean-Francois Moine wrote: > > This patch adds a CODEC to the NXP TDA998x HDMI transmitter. [snip] > >

[PATCH v9 3/4] ASoC: tda998x: add a codec to the HDMI transmitter

2015-01-11 Thread Jyri Sarha
Some more comments based on my - finally successful - attempt to use this code with BBB HDMI audio. On 01/07/2015 12:51 PM, Jean-Francois Moine wrote: > This patch adds a CODEC to the NXP TDA998x HDMI transmitter. > > The CODEC handles both I2S and S/PDIF inputs. > It maintains the audio format a

[PATCH v9 3/4] ASoC: tda998x: add a codec to the HDMI transmitter

2015-01-09 Thread Mark Brown
On Fri, Jan 09, 2015 at 05:39:08PM +, Andrew Jackson wrote: > In the light of our discussions elsewhere [1], shouldn't this > be constrained by the number of hardware channels that the TDA998x > supports too? That is, the maximum number of channels should > be the lesser of sd[SAD_MX_CHAN_I]

[PATCH v9 3/4] ASoC: tda998x: add a codec to the HDMI transmitter

2015-01-09 Thread Andrew Jackson
On 01/07/15 10:51, Jean-Francois Moine wrote: > This patch adds a CODEC to the NXP TDA998x HDMI transmitter. > > The CODEC handles both I2S and S/PDIF inputs. > It maintains the audio format and rate constraints according > to the HDMI device parameters (EDID) and sets dynamically the input > port

[PATCH v9 3/4] ASoC: tda998x: add a codec to the HDMI transmitter

2015-01-09 Thread Jean-Francois Moine
On Fri, 9 Jan 2015 11:19:35 + Russell King - ARM Linux wrote: > Would it be more sensible to make SND_SOC_TDA998X depend on > DRM_I2C_NXP_TDA998X instead, maybe with a 'default y' - which is a > kinder way to have SND_SOC_TDA998X be enabled. If SND_SOC_TDA998X > doesn't have a prompt, then i

[PATCH v9 3/4] ASoC: tda998x: add a codec to the HDMI transmitter

2015-01-09 Thread Jyri Sarha
On 01/07/2015 08:02 PM, Jean-Francois Moine wrote: > On Wed, 7 Jan 2015 15:41:38 + > Russell King - ARM Linux wrote: > >> On Wed, Jan 07, 2015 at 03:10:47PM +, Andrew Jackson wrote: >>> On 01/07/15 10:51, Jean-Francois Moine wrote: diff --git a/drivers/gpu/drm/i2c/Kconfig b/drivers/gp

[PATCH v9 3/4] ASoC: tda998x: add a codec to the HDMI transmitter

2015-01-09 Thread Jean-Francois Moine
On Fri, 9 Jan 2015 12:24:12 +0200 Jyri Sarha wrote: > > select SND_SOC_TDA998X if SND_SOC > > > > should work in all cases. > > > > I think that would still fail if DRM and TDA998x is built in and SND_SOC > is built as modules. A request_module() call before > tda9998x_codec_register() s

[PATCH v9 3/4] ASoC: tda998x: add a codec to the HDMI transmitter

2015-01-09 Thread Russell King - ARM Linux
On Fri, Jan 09, 2015 at 12:45:31PM +0100, Jean-Francois Moine wrote: > On Fri, 9 Jan 2015 11:19:35 + > Russell King - ARM Linux wrote: > > > Would it be more sensible to make SND_SOC_TDA998X depend on > > DRM_I2C_NXP_TDA998X instead, maybe with a 'default y' - which is a > > kinder way to hav

[PATCH v9 3/4] ASoC: tda998x: add a codec to the HDMI transmitter

2015-01-09 Thread Russell King - ARM Linux
On Fri, Jan 09, 2015 at 12:24:12PM +0200, Jyri Sarha wrote: > I think that would still fail if DRM and TDA998x is built in and SND_SOC is > built as modules. A request_module() call before tda9998x_codec_register() > should help. That doesn't fix the problem. If the DRM driver is built in, but th

[PATCH v9 3/4] ASoC: tda998x: add a codec to the HDMI transmitter

2015-01-08 Thread Jyri Sarha
On 01/07/2015 12:51 PM, Jean-Francois Moine wrote: > This patch adds a CODEC to the NXP TDA998x HDMI transmitter. > > The CODEC handles both I2S and S/PDIF inputs. > It maintains the audio format and rate constraints according > to the HDMI device parameters (EDID) and sets dynamically the input >

[PATCH v9 3/4] ASoC: tda998x: add a codec to the HDMI transmitter

2015-01-07 Thread Jean-Francois Moine
On Wed, 7 Jan 2015 15:41:38 + Russell King - ARM Linux wrote: > On Wed, Jan 07, 2015 at 03:10:47PM +, Andrew Jackson wrote: > > On 01/07/15 10:51, Jean-Francois Moine wrote: > > > diff --git a/drivers/gpu/drm/i2c/Kconfig b/drivers/gpu/drm/i2c/Kconfig > > > index 22c7ed6..24fc975 100644 >

[PATCH v9 3/4] ASoC: tda998x: add a codec to the HDMI transmitter

2015-01-07 Thread Mark Brown
On Wed, Jan 07, 2015 at 03:10:47PM +, Andrew Jackson wrote: > On 01/07/15 10:51, Jean-Francois Moine wrote: > > This patch adds a CODEC to the NXP TDA998x HDMI transmitter. > > > > The CODEC handles both I2S and S/PDIF inputs. Please delete unneeded context from your messages, it makes it muc

[PATCH v9 3/4] ASoC: tda998x: add a codec to the HDMI transmitter

2015-01-07 Thread Russell King - ARM Linux
On Wed, Jan 07, 2015 at 03:10:47PM +, Andrew Jackson wrote: > On 01/07/15 10:51, Jean-Francois Moine wrote: > > diff --git a/drivers/gpu/drm/i2c/Kconfig b/drivers/gpu/drm/i2c/Kconfig > > index 22c7ed6..24fc975 100644 > > --- a/drivers/gpu/drm/i2c/Kconfig > > +++ b/drivers/gpu/drm/i2c/Kconfig >

[PATCH v9 3/4] ASoC: tda998x: add a codec to the HDMI transmitter

2015-01-07 Thread Andrew Jackson
On 01/07/15 10:51, Jean-Francois Moine wrote: > This patch adds a CODEC to the NXP TDA998x HDMI transmitter. > > The CODEC handles both I2S and S/PDIF inputs. > It maintains the audio format and rate constraints according > to the HDMI device parameters (EDID) and sets dynamically the input > port

[PATCH v9 3/4] ASoC: tda998x: add a codec to the HDMI transmitter

2015-01-07 Thread Jean-Francois Moine
This patch adds a CODEC to the NXP TDA998x HDMI transmitter. The CODEC handles both I2S and S/PDIF inputs. It maintains the audio format and rate constraints according to the HDMI device parameters (EDID) and sets dynamically the input ports in the TDA998x I2C driver on start/stop audio streaming.