Re: [PATCH v9 23/25] mm/gup: track FOLL_PIN pages

2019-12-17 Thread kbuild test robot
Hi John, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on rdma/for-next] [also build test WARNING on linus/master v5.5-rc2 next-20191216] [cannot apply to mmotm/master vfio/next] [if your patch is applied to the wrong git tree, please drop us a note to help impro

Re: [PATCH v9 23/25] mm/gup: track FOLL_PIN pages

2019-12-11 Thread John Hubbard
On 12/11/19 3:28 AM, Jan Kara wrote: ... The patch looks mostly good to me now. Just a few smaller comments below. Suggested-by: Jan Kara Suggested-by: Jérôme Glisse Reviewed-by: Jan Kara Reviewed-by: Jérôme Glisse Reviewed-by: Ira Weiny I think you inherited here the Reviewed-by tags f

Re: [PATCH v9 23/25] mm/gup: track FOLL_PIN pages

2019-12-11 Thread Jan Kara
On Tue 10-12-19 18:53:16, John Hubbard wrote: > Add tracking of pages that were pinned via FOLL_PIN. > > As mentioned in the FOLL_PIN documentation, callers who effectively set > FOLL_PIN are required to ultimately free such pages via unpin_user_page(). > The effect is similar to FOLL_GET, and may

[PATCH v9 23/25] mm/gup: track FOLL_PIN pages

2019-12-10 Thread John Hubbard
Add tracking of pages that were pinned via FOLL_PIN. As mentioned in the FOLL_PIN documentation, callers who effectively set FOLL_PIN are required to ultimately free such pages via unpin_user_page(). The effect is similar to FOLL_GET, and may be thought of as "FOLL_GET for DIO and/or RDMA use". P