Re: [PATCH v8 10/26] memory: tegra30-emc: Factor out clk initialization

2020-11-12 Thread Dmitry Osipenko
11.11.2020 11:52, Krzysztof Kozlowski пишет: >> You added this code in patch #8, so adding-and-removing a piece of code > Correction: you added this in patch #9. > > Best regards, > Krzysztof > > >> is a nice hint that this patch should be before. Don't add new code >> which later you simplify.

Re: [PATCH v8 10/26] memory: tegra30-emc: Factor out clk initialization

2020-11-11 Thread Krzysztof Kozlowski
On Wed, Nov 11, 2020 at 09:51:15AM +0100, Krzysztof Kozlowski wrote: > On Wed, Nov 11, 2020 at 04:14:40AM +0300, Dmitry Osipenko wrote: > > Factor out clk initialization and make it resource-managed. This makes > > easier to follow code and will help to make further changes cleaner. > > > > Signed

Re: [PATCH v8 10/26] memory: tegra30-emc: Factor out clk initialization

2020-11-11 Thread Krzysztof Kozlowski
On Wed, Nov 11, 2020 at 04:14:40AM +0300, Dmitry Osipenko wrote: > Factor out clk initialization and make it resource-managed. This makes > easier to follow code and will help to make further changes cleaner. > > Signed-off-by: Dmitry Osipenko > --- > drivers/memory/tegra/tegra30-emc.c | 70

[PATCH v8 10/26] memory: tegra30-emc: Factor out clk initialization

2020-11-10 Thread Dmitry Osipenko
Factor out clk initialization and make it resource-managed. This makes easier to follow code and will help to make further changes cleaner. Signed-off-by: Dmitry Osipenko --- drivers/memory/tegra/tegra30-emc.c | 70 -- 1 file changed, 47 insertions(+), 23 deletions(-)