Re: [PATCH v8 07/17] pwm: lpss: Always update state and set update bit

2020-08-31 Thread Thierry Reding
On Mon, Aug 31, 2020 at 01:26:46PM +0200, Hans de Goede wrote: > Hi, > > On 8/31/20 1:13 PM, Thierry Reding wrote: > > On Sun, Aug 30, 2020 at 02:57:43PM +0200, Hans de Goede wrote: > > > This commit removes a check where we would skip writing the ctrl register > > > and then setting the update bi

Re: [PATCH v8 07/17] pwm: lpss: Always update state and set update bit

2020-08-31 Thread Hans de Goede
Hi, On 8/31/20 10:56 AM, Andy Shevchenko wrote: On Sun, Aug 30, 2020 at 02:57:43PM +0200, Hans de Goede wrote: This commit removes a check where we would skip writing the ctrl register and then setting the update bit in case the ctrl register already contains the correct values. In a perfect w

Re: [PATCH v8 07/17] pwm: lpss: Always update state and set update bit

2020-08-31 Thread Hans de Goede
Hi, On 8/31/20 1:13 PM, Thierry Reding wrote: On Sun, Aug 30, 2020 at 02:57:43PM +0200, Hans de Goede wrote: This commit removes a check where we would skip writing the ctrl register and then setting the update bit in case the ctrl register already contains the correct values. In a perfect wor

Re: [PATCH v8 07/17] pwm: lpss: Always update state and set update bit

2020-08-31 Thread Thierry Reding
On Sun, Aug 30, 2020 at 02:57:43PM +0200, Hans de Goede wrote: > This commit removes a check where we would skip writing the ctrl register > and then setting the update bit in case the ctrl register already contains > the correct values. > > In a perfect world skipping the update should be fine in

Re: [PATCH v8 07/17] pwm: lpss: Always update state and set update bit

2020-08-31 Thread Andy Shevchenko
On Sun, Aug 30, 2020 at 02:57:43PM +0200, Hans de Goede wrote: > This commit removes a check where we would skip writing the ctrl register > and then setting the update bit in case the ctrl register already contains > the correct values. > > In a perfect world skipping the update should be fine in

[PATCH v8 07/17] pwm: lpss: Always update state and set update bit

2020-08-30 Thread Hans de Goede
This commit removes a check where we would skip writing the ctrl register and then setting the update bit in case the ctrl register already contains the correct values. In a perfect world skipping the update should be fine in these cases, but on Cherry Trail devices the AML code in the GFX0 device