Re: [PATCH v8 06/17] pwm: lpss: Use pwm_lpss_restore() when restoring state on resume

2020-09-01 Thread Andy Shevchenko
On Mon, Aug 31, 2020 at 07:57:30PM +0200, Hans de Goede wrote: > On 8/31/20 3:15 PM, Thierry Reding wrote: > > On Mon, Aug 31, 2020 at 01:46:28PM +0200, Hans de Goede wrote: > > > On 8/31/20 1:10 PM, Thierry Reding wrote: > > > > On Sun, Aug 30, 2020 at 02:57:42PM +0200, Hans de Goede wrote: > > >

Re: [PATCH v8 06/17] pwm: lpss: Use pwm_lpss_restore() when restoring state on resume

2020-08-31 Thread Hans de Goede
Hi, On 8/31/20 3:15 PM, Thierry Reding wrote: On Mon, Aug 31, 2020 at 01:46:28PM +0200, Hans de Goede wrote: Hi, On 8/31/20 1:10 PM, Thierry Reding wrote: On Sun, Aug 30, 2020 at 02:57:42PM +0200, Hans de Goede wrote: Before this commit a suspend + resume of the LPSS PWM controller would res

Re: [PATCH v8 06/17] pwm: lpss: Use pwm_lpss_restore() when restoring state on resume

2020-08-31 Thread Thierry Reding
On Mon, Aug 31, 2020 at 01:46:28PM +0200, Hans de Goede wrote: > Hi, > > On 8/31/20 1:10 PM, Thierry Reding wrote: > > On Sun, Aug 30, 2020 at 02:57:42PM +0200, Hans de Goede wrote: > > > Before this commit a suspend + resume of the LPSS PWM controller > > > would result in the controller being re

Re: [PATCH v8 06/17] pwm: lpss: Use pwm_lpss_restore() when restoring state on resume

2020-08-31 Thread Hans de Goede
Hi, On 8/31/20 1:10 PM, Thierry Reding wrote: On Sun, Aug 30, 2020 at 02:57:42PM +0200, Hans de Goede wrote: Before this commit a suspend + resume of the LPSS PWM controller would result in the controller being reset to its defaults of output-freq = clock/256, duty-cycle=100%, until someone cha

Re: [PATCH v8 06/17] pwm: lpss: Use pwm_lpss_restore() when restoring state on resume

2020-08-31 Thread Thierry Reding
On Sun, Aug 30, 2020 at 02:57:42PM +0200, Hans de Goede wrote: > Before this commit a suspend + resume of the LPSS PWM controller > would result in the controller being reset to its defaults of > output-freq = clock/256, duty-cycle=100%, until someone changes > to the output-freq and/or duty-cycle

[PATCH v8 06/17] pwm: lpss: Use pwm_lpss_restore() when restoring state on resume

2020-08-30 Thread Hans de Goede
Before this commit a suspend + resume of the LPSS PWM controller would result in the controller being reset to its defaults of output-freq = clock/256, duty-cycle=100%, until someone changes to the output-freq and/or duty-cycle are made. This problem has been masked so far because the main consume