Re: [PATCH v7 1/9] of: property: add of_graph_get_next_port()

2024-10-23 Thread Kuninori Morimoto
Hi Sakari > > > > + * Parent device node can be used as @parent whether device node has > > > > ports node or not. > > > > > > This line should be wrapped, no reason to have it longer than 80 chars. > > > > We can use 100 char now on upstream ? > > > > commit bdc48fa11e46f867ea4d75fa59ee

Re: [PATCH v7 1/9] of: property: add of_graph_get_next_port()

2024-10-23 Thread Sakari Ailus
Dear Morimoto-san, On Wed, Oct 23, 2024 at 04:40:45AM +, Kuninori Morimoto wrote: > > Hi Sakari, again > > > > diff --git a/drivers/of/property.c b/drivers/of/property.c > > > index 11b922fde7af..6a5d27dd0c64 100644 > > > --- a/drivers/of/property.c > > > +++ b/drivers/of/property.c > > > @@

Re: [PATCH v7 1/9] of: property: add of_graph_get_next_port()

2024-10-22 Thread Kuninori Morimoto
Hi Sakari, again > > diff --git a/drivers/of/property.c b/drivers/of/property.c > > index 11b922fde7af..6a5d27dd0c64 100644 > > --- a/drivers/of/property.c > > +++ b/drivers/of/property.c > > @@ -630,6 +630,43 @@ struct device_node *of_graph_get_port_by_id(struct > > device_node *parent, u32 id

Re: [PATCH v7 1/9] of: property: add of_graph_get_next_port()

2024-10-21 Thread Kuninori Morimoto
Hi Sakari, Rob > > +/** > > + * of_graph_get_next_port() - get next port node. > > + * @parent: pointer to the parent device node, or parent ports node > > + * @prev: previous port node, or NULL to get first > > + * > > + * Parent device node can be used as @parent whether device node has ports

Re: [PATCH v7 1/9] of: property: add of_graph_get_next_port()

2024-10-21 Thread Sakari Ailus
Dead Morimoto-san, On Wed, Oct 09, 2024 at 01:44:48AM +, Kuninori Morimoto wrote: > diff --git a/drivers/of/property.c b/drivers/of/property.c > index 11b922fde7af..6a5d27dd0c64 100644 > --- a/drivers/of/property.c > +++ b/drivers/of/property.c > @@ -630,6 +630,43 @@ struct device_node *of_gra

[PATCH v7 1/9] of: property: add of_graph_get_next_port()

2024-10-08 Thread Kuninori Morimoto
We have endpoint base functions - of_graph_get_next_endpoint() - of_graph_get_endpoint_count() - for_each_endpoint_of_node() Here, for_each_endpoint_of_node() loop finds each endpoints ports { port@0 { (1) endpoint {...};