Den 09.10.2017 11.06, skrev Daniel Thompson:
On 06/10/17 19:01, Noralf Trønnes wrote:
Den 03.10.2017 11.04, skrev Daniel Vetter:
On Tue, Oct 03, 2017 at 09:51:49AM +0100, Daniel Thompson wrote:
On 03/10/17 09:03, Daniel Vetter wrote:
On Mon, Oct 02, 2017 at 12:00:54PM +0300, Jani Nikula wro
On 06/10/17 19:01, Noralf Trønnes wrote:
Den 03.10.2017 11.04, skrev Daniel Vetter:
On Tue, Oct 03, 2017 at 09:51:49AM +0100, Daniel Thompson wrote:
On 03/10/17 09:03, Daniel Vetter wrote:
On Mon, Oct 02, 2017 at 12:00:54PM +0300, Jani Nikula wrote:
On Mon, 02 Oct 2017, Daniel Thompson
wrot
Den 03.10.2017 11.04, skrev Daniel Vetter:
On Tue, Oct 03, 2017 at 09:51:49AM +0100, Daniel Thompson wrote:
On 03/10/17 09:03, Daniel Vetter wrote:
On Mon, Oct 02, 2017 at 12:00:54PM +0300, Jani Nikula wrote:
On Mon, 02 Oct 2017, Daniel Thompson wrote:
So I'm coming to this patchset cold bu
On Tue, Oct 03, 2017 at 09:51:49AM +0100, Daniel Thompson wrote:
> On 03/10/17 09:03, Daniel Vetter wrote:
> > On Mon, Oct 02, 2017 at 12:00:54PM +0300, Jani Nikula wrote:
> > > On Mon, 02 Oct 2017, Daniel Thompson wrote:
> > > > So I'm coming to this patchset cold but can you explain *why* someth
On 03/10/17 09:03, Daniel Vetter wrote:
On Mon, Oct 02, 2017 at 12:00:54PM +0300, Jani Nikula wrote:
On Mon, 02 Oct 2017, Daniel Thompson wrote:
So I'm coming to this patchset cold but can you explain *why* something
wants to call of_find_backlight_by_node() when there is no backlight
support
On Mon, Oct 02, 2017 at 12:00:54PM +0300, Jani Nikula wrote:
> On Mon, 02 Oct 2017, Daniel Thompson wrote:
> > So I'm coming to this patchset cold but can you explain *why* something
> > wants to call of_find_backlight_by_node() when there is no backlight
> > support enabled. Why isn't the code
On Mon, 02 Oct 2017, Daniel Thompson wrote:
> On 02/10/17 09:49, Jani Nikula wrote:
>> On Mon, 02 Oct 2017, Daniel Thompson wrote:
>>> On 01/10/17 18:26, Meghana Madhyastha wrote:
-#ifdef CONFIG_OF
+#if defined CONFIG_OF && IS_ENABLED(CONFIG_BACKLIGHT_CLASS_DEVICE)
>>>
>>> The above com
On 02/10/17 09:49, Jani Nikula wrote:
On Mon, 02 Oct 2017, Daniel Thompson wrote:
On 01/10/17 18:26, Meghana Madhyastha wrote:
-#ifdef CONFIG_OF
+#if defined CONFIG_OF && IS_ENABLED(CONFIG_BACKLIGHT_CLASS_DEVICE)
The above comments are more important but why does this mix defined and
IS_ENAB
On Mon, 02 Oct 2017, Daniel Thompson wrote:
> So I'm coming to this patchset cold but can you explain *why* something
> wants to call of_find_backlight_by_node() when there is no backlight
> support enabled. Why isn't the code that called is conditional on
> BACKLIGHT_CLASS_DEVICE?
>
> The unde
On Mon, 02 Oct 2017, Daniel Thompson wrote:
> On 01/10/17 18:26, Meghana Madhyastha wrote:
>> -#ifdef CONFIG_OF
>> +#if defined CONFIG_OF && IS_ENABLED(CONFIG_BACKLIGHT_CLASS_DEVICE)
>
> The above comments are more important but why does this mix defined and
> IS_ENABLED? Couldn't they both use d
On 02/10/17 06:58, Daniel Thompson wrote:
On 01/10/17 18:26, Meghana Madhyastha wrote:
Add IS_ENABLED(CONFIG_BACKLIGHT_CLASS_DEVICE) as part of the
if directive for the function declaration of
of_find_backlight_by_node in order to avoid module dependency
errors.
Module dependency errors? Does
On 01/10/17 18:26, Meghana Madhyastha wrote:
Add IS_ENABLED(CONFIG_BACKLIGHT_CLASS_DEVICE) as part of the
if directive for the function declaration of
of_find_backlight_by_node in order to avoid module dependency
errors.
Module dependency errors? Does you mean mean use of undefined symbols?
Add IS_ENABLED(CONFIG_BACKLIGHT_CLASS_DEVICE) as part of the
if directive for the function declaration of
of_find_backlight_by_node in order to avoid module dependency
errors.
Signed-off-by: Meghana Madhyastha
---
Changes in v7:
-This patch did not exist in v6.
include/linux/backlight.h | 2 +-
13 matches
Mail list logo
