Re: [PATCH v7 1/2] drm/panel: Add support for Truly NT35597 panel driver

2018-09-21 Thread Bjorn Andersson
On Wed 19 Sep 19:55 PDT 2018, Abhinav Kumar wrote: > +static int truly_nt35597_probe(struct mipi_dsi_device *dsi) > +{ [..] > + dsi1 = of_graph_get_remote_node(dsi->dev.of_node, 1, -1); > + if (!dsi1) { > + DRM_DEV_ERROR(dev, > + "failed to get remote node fo

Re: [PATCH v7 1/2] drm/panel: Add support for Truly NT35597 panel driver

2018-09-20 Thread Abhinav Kumar
Hi Bjorn Thanks for the comment. Yes, I will move of_node_put(dsi1) to right after of_find_mipi_dsi_host_by_node and remove it from err_dsi_device. Thanks Abhinav On 2018-09-20 09:54, Bjorn Andersson wrote: On Wed 19 Sep 19:55 PDT 2018, Abhinav Kumar wrote: +static int truly_nt35597_probe(

Re: [PATCH v7 1/2] drm/panel: Add support for Truly NT35597 panel driver

2018-09-20 Thread Abhinav Kumar
Hi Sean Sure, I will address these in v8. Thanks Abhinav On 2018-09-20 08:52, Sean Paul wrote: On Wed, Sep 19, 2018 at 07:55:39PM -0700, Abhinav Kumar wrote: From: "abhin...@codeaurora.org" Add support for Truly NT35597 panel driver used in MSM reference platforms. This panel driver suppor

Re: [PATCH v7 1/2] drm/panel: Add support for Truly NT35597 panel driver

2018-09-20 Thread Sean Paul
On Wed, Sep 19, 2018 at 07:55:39PM -0700, Abhinav Kumar wrote: > From: "abhin...@codeaurora.org" > > Add support for Truly NT35597 panel driver used > in MSM reference platforms. > > This panel driver supports both single DSI and dual DSI > modes. > > However, this patch series adds support onl

[PATCH v7 1/2] drm/panel: Add support for Truly NT35597 panel driver

2018-09-19 Thread Abhinav Kumar
From: "abhin...@codeaurora.org" Add support for Truly NT35597 panel driver used in MSM reference platforms. This panel driver supports both single DSI and dual DSI modes. However, this patch series adds support only for dual DSI mode. Changes in v7: - Make the panel commands, name and mode as