Re: [PATCH v7 03/12] drm/bridge: cdns-dsi: Fix phy de-init and flag it so

2025-01-17 Thread Aradhya Bhatia
Hi Tomi, On 15/01/25 13:47, Tomi Valkeinen wrote: > Hi, > > On 14/01/2025 18:32, Aradhya Bhatia wrote: > >>> But generally speaking, yes, it's good to keep fixes simple, and do >>> cleanups later on top. Keeping that in mind, maybe this current patch is >>> fine as it is. Although... if the init

Re: [PATCH v7 03/12] drm/bridge: cdns-dsi: Fix phy de-init and flag it so

2025-01-15 Thread Tomi Valkeinen
Hi, On 14/01/2025 18:32, Aradhya Bhatia wrote: But generally speaking, yes, it's good to keep fixes simple, and do cleanups later on top. Keeping that in mind, maybe this current patch is fine as it is. Although... if the init is done in pre_enable, shouldn't the deinit be done in post_disable?

Re: [PATCH v7 03/12] drm/bridge: cdns-dsi: Fix phy de-init and flag it so

2025-01-14 Thread Aradhya Bhatia
Hi, On 1/14/25 20:50, Tomi Valkeinen wrote: > Hi, > > On 14/01/2025 16:44, Aradhya Bhatia wrote: >> Hi Tomi, >> >> On 1/14/25 18:00, Tomi Valkeinen wrote: >>> Hi, >>> >>> On 14/01/2025 07:56, Aradhya Bhatia wrote: From: Aradhya Bhatia The driver code doesn't have a Phy de-initiali

Re: [PATCH v7 03/12] drm/bridge: cdns-dsi: Fix phy de-init and flag it so

2025-01-14 Thread Tomi Valkeinen
Hi, On 14/01/2025 16:44, Aradhya Bhatia wrote: Hi Tomi, On 1/14/25 18:00, Tomi Valkeinen wrote: Hi, On 14/01/2025 07:56, Aradhya Bhatia wrote: From: Aradhya Bhatia The driver code doesn't have a Phy de-initialization path as yet, and so it does not clear the phy_initialized flag while susp

Re: [PATCH v7 03/12] drm/bridge: cdns-dsi: Fix phy de-init and flag it so

2025-01-14 Thread Aradhya Bhatia
Hi Tomi, On 1/14/25 18:00, Tomi Valkeinen wrote: > Hi, > > On 14/01/2025 07:56, Aradhya Bhatia wrote: >> From: Aradhya Bhatia >> >> The driver code doesn't have a Phy de-initialization path as yet, and so >> it does not clear the phy_initialized flag while suspending. This is a >> problem becaus

Re: [PATCH v7 03/12] drm/bridge: cdns-dsi: Fix phy de-init and flag it so

2025-01-14 Thread Tomi Valkeinen
Hi, On 14/01/2025 07:56, Aradhya Bhatia wrote: From: Aradhya Bhatia The driver code doesn't have a Phy de-initialization path as yet, and so it does not clear the phy_initialized flag while suspending. This is a problem because after resume the driver looks at this flag to determine if a Phy r

[PATCH v7 03/12] drm/bridge: cdns-dsi: Fix phy de-init and flag it so

2025-01-13 Thread Aradhya Bhatia
From: Aradhya Bhatia The driver code doesn't have a Phy de-initialization path as yet, and so it does not clear the phy_initialized flag while suspending. This is a problem because after resume the driver looks at this flag to determine if a Phy re-initialization is required or not. It is in fact