Re: [PATCH v6 3/6] drm: Add driver for Solomon SSD130x OLED displays

2022-06-13 Thread Javier Martinez Canillas
Hello Dominik, On 6/13/22 13:39, Dominik Kierner wrote: Removed the regmap part since Andy already commented and I agree with him. >>> Splitting in VCC/VBAT and VDD and enforcing their presence is of >>> course compatibility breaking. >>> >>> https://github.com/dh-electronics/panel-solomon-ssd13

Re: [PATCH v6 3/6] drm: Add driver for Solomon SSD130x OLED displays

2022-06-13 Thread Javier Martinez Canillas
On 6/13/22 17:35, andriy.shevche...@linux.intel.com wrote: > On Mon, Jun 13, 2022 at 11:39:30AM +, Dominik Kierner wrote: >> On 5/25/2022 21:46, Javier Martinez Canillas wrote: > > ... > >>> Thanks, I looked at the code briefly and think that there are things there >>> that we >>> could use.

Re: [PATCH v6 3/6] drm: Add driver for Solomon SSD130x OLED displays

2022-06-13 Thread andriy.shevche...@linux.intel.com
On Mon, Jun 13, 2022 at 11:39:30AM +, Dominik Kierner wrote: > On 5/25/2022 21:46, Javier Martinez Canillas wrote: ... > > Thanks, I looked at the code briefly and think that there are things there > > that we > > could use. I.e the 3-wire SPI support that's in > > panel-solomon-ssd130x-spi

Re: [PATCH v6 3/6] drm: Add driver for Solomon SSD130x OLED displays

2022-06-01 Thread andriy.shevche...@linux.intel.com
On Wed, May 25, 2022 at 09:46:24PM +0200, Javier Martinez Canillas wrote: > On 3/10/22 14:11, Dominik Kierner wrote: ... > > # DRM Mode Configuration via Device Tree > > > > In the old fbdev driver, the display modes are hard-coded, which means > > for every new display configuration, a new patc

Re: [PATCH v6 3/6] drm: Add driver for Solomon SSD130x OLED displays

2022-05-25 Thread Javier Martinez Canillas
Hello Dominik, I missed this email before and never answered. Sorry about that. On 3/10/22 14:11, Dominik Kierner wrote: > Hello Javier, > > I was working on a SSD130x driver as well, although with a different > (drm_panel) approach and hit a bit of a roadblock. My first attempt also was using

Re: [PATCH v6 3/6] drm: Add driver for Solomon SSD130x OLED displays

2022-03-09 Thread Javier Martinez Canillas
Hello Geert, On 3/9/22 21:04, Geert Uytterhoeven wrote: [snip] >> + >> + /* Last page may be partial */ >> + if (8 * (i + 1) > ssd130x->height) >> + m = ssd130x->height % 8; >> + for (j = x; j < x + width; j++) { >> +

Re: [PATCH v6 3/6] drm: Add driver for Solomon SSD130x OLED displays

2022-03-09 Thread Geert Uytterhoeven
Hi Javier, On Mon, Feb 14, 2022 at 2:37 PM Javier Martinez Canillas wrote: > This adds a DRM driver for SSD1305, SSD1306, SSD1307 and SSD1309 Solomon > OLED display controllers. > > It's only the core part of the driver and a bus specific driver is needed > for each transport interface supported

Re: [PATCH v6 3/6] drm: Add driver for Solomon SSD130x OLED displays

2022-03-09 Thread Javier Martinez Canillas
Hello Geert, On 3/9/22 13:56, Geert Uytterhoeven wrote: > Hi Javier, > > On Wed, Mar 9, 2022 at 1:14 PM Javier Martinez Canillas > wrote: >> On 3/8/22 17:30, Geert Uytterhoeven wrote: >>> Unfortunately a regression was introduced since your v3: printed >>> text is mirrored upside-down. I.e. "E"

Re: [PATCH v6 3/6] drm: Add driver for Solomon SSD130x OLED displays

2022-03-09 Thread Geert Uytterhoeven
Hi Javier, On Wed, Mar 9, 2022 at 1:14 PM Javier Martinez Canillas wrote: > On 3/8/22 17:30, Geert Uytterhoeven wrote: > > Unfortunately a regression was introduced since your v3: printed > > text is mirrored upside-down. I.e. "E" is rendered correctly, but "L" > > turns into "Γ" (Greek Gamma). >

Re: [PATCH v6 3/6] drm: Add driver for Solomon SSD130x OLED displays

2022-03-09 Thread Javier Martinez Canillas
On 3/8/22 17:30, Geert Uytterhoeven wrote: > Hi Javier, > > On Mon, Feb 14, 2022 at 2:37 PM Javier Martinez Canillas > wrote: >> This adds a DRM driver for SSD1305, SSD1306, SSD1307 and SSD1309 Solomon >> OLED display controllers. >> >> It's only the core part of the driver and a bus specific dri

Re: [PATCH v6 3/6] drm: Add driver for Solomon SSD130x OLED displays

2022-03-08 Thread Geert Uytterhoeven
Hi Javier, On Mon, Feb 14, 2022 at 2:37 PM Javier Martinez Canillas wrote: > This adds a DRM driver for SSD1305, SSD1306, SSD1307 and SSD1309 Solomon > OLED display controllers. > > It's only the core part of the driver and a bus specific driver is needed > for each transport interface supported

Re: [PATCH v6 3/6] drm: Add driver for Solomon SSD130x OLED displays

2022-02-16 Thread Maxime Ripard
On Mon, Feb 14, 2022 at 02:37:07PM +0100, Javier Martinez Canillas wrote: > This adds a DRM driver for SSD1305, SSD1306, SSD1307 and SSD1309 Solomon > OLED display controllers. > > It's only the core part of the driver and a bus specific driver is needed > for each transport interface supported by

[PATCH v6 3/6] drm: Add driver for Solomon SSD130x OLED displays

2022-02-14 Thread Javier Martinez Canillas
This adds a DRM driver for SSD1305, SSD1306, SSD1307 and SSD1309 Solomon OLED display controllers. It's only the core part of the driver and a bus specific driver is needed for each transport interface supported by the display controllers. Signed-off-by: Javier Martinez Canillas --- Changes in