On Tue, Apr 02, 2024 at 12:36:41PM +, Akhil R wrote:
>
> Should I set the reqsize as below in sha_cra_init()? Seeing this in other
> crypto drivers.
>
> crypto_ahash_set_reqsize(ahash_tfm,
> sizeof(struct tegra_sha_reqctx) +
> crypto_aha
> On Tue, Mar 19, 2024 at 01:53:04PM +0530, Akhil R wrote:
> >
> > +struct tegra_sha_reqctx {
> > + struct ahash_request fallback_req;
>
> This doesn't work because ahash_request is dynamically sized.
> So you'll end up clobbering the rest of the struct if a fallback ends up
> being used.
>
> >
> > + .alg.skcipher.op.do_one_request = tegra_aes_do_one_req,
> > + .alg.skcipher.base = {
> > + .init = tegra_aes_cra_init,
> > + .exit = tegra_aes_cra_exit,
> > + .setkey = tegra_aes_setkey,
> > +
On Tue, Mar 19, 2024 at 01:53:04PM +0530, Akhil R wrote:
>
> +struct tegra_sha_reqctx {
> + struct ahash_request fallback_req;
This doesn't work because ahash_request is dynamically sized.
So you'll end up clobbering the rest of the struct if a fallback
ends up being used.
You should place th
On Tue, Mar 19, 2024 at 01:53:04PM +0530, Akhil R wrote:
>
> + .alg.skcipher.op.do_one_request = tegra_aes_do_one_req,
> + .alg.skcipher.base = {
> + .init = tegra_aes_cra_init,
> + .exit = tegra_aes_cra_exit,
> + .
Add support for Tegra Security Engine which can accelerate various
crypto algorithms. The Engine has two separate instances within for
AES and HASH algorithms respectively.
The driver registers two crypto engines - one for AES and another for
HASH algorithms and these operate independently and bot
