Re: [PATCH v6 21/23] drm: rockchip: Add VOP2 driver

2022-02-25 Thread Dmitry Osipenko
On 2/24/22 10:47, Sascha Hauer wrote: > On Thu, Feb 17, 2022 at 04:24:29PM +0300, Dmitry Osipenko wrote: >> 17.02.2022 11:29, Sascha Hauer пишет: >>> @@ -28,6 +28,12 @@ config ROCKCHIP_VOP >>> This selects support for the VOP driver. You should enable it >>> on all older SoCs up to RK33

Re: [PATCH v6 21/23] drm: rockchip: Add VOP2 driver

2022-02-24 Thread Sascha Hauer
On Thu, Feb 24, 2022 at 05:36:29PM +0300, Dmitry Osipenko wrote: > On 2/24/22 10:47, Sascha Hauer wrote: > > On Thu, Feb 17, 2022 at 04:24:29PM +0300, Dmitry Osipenko wrote: > >> 17.02.2022 11:29, Sascha Hauer пишет: > >>> @@ -28,6 +28,12 @@ config ROCKCHIP_VOP > >>> This selects support for th

Re: [PATCH v6 21/23] drm: rockchip: Add VOP2 driver

2022-02-24 Thread Sascha Hauer
On Thu, Feb 24, 2022 at 06:54:35PM +0800, Andy Yan wrote: > Hi Sascha: > > On 2/24/22 16:19, Sascha Hauer wrote: > > On Sat, Feb 19, 2022 at 03:35:12PM +0800, Andy Yan wrote: > > > Hi Sascha: > > > > > > On 2/18/22 16:00, Sascha Hauer wrote: > > > > On Fri, Feb 18, 2022 at 11:50:32AM +0800, Andy

Re: [PATCH v6 21/23] drm: rockchip: Add VOP2 driver

2022-02-24 Thread Andy Yan
Hi Sascha: On 2/24/22 16:19, Sascha Hauer wrote: On Sat, Feb 19, 2022 at 03:35:12PM +0800, Andy Yan wrote: Hi Sascha: On 2/18/22 16:00, Sascha Hauer wrote: On Fri, Feb 18, 2022 at 11:50:32AM +0800, Andy Yan wrote: Hi Sascha: On 2/17/22 22:06, Heiko Stübner wrote: Am Donnerstag, 17. Februar

Re: [PATCH v6 21/23] drm: rockchip: Add VOP2 driver

2022-02-24 Thread Sascha Hauer
On Sat, Feb 19, 2022 at 03:35:12PM +0800, Andy Yan wrote: > Hi Sascha: > > On 2/18/22 16:00, Sascha Hauer wrote: > > On Fri, Feb 18, 2022 at 11:50:32AM +0800, Andy Yan wrote: > > > Hi Sascha: > > > > > > On 2/17/22 22:06, Heiko Stübner wrote: > > > > Am Donnerstag, 17. Februar 2022, 14:58:23 CET

Re: [PATCH v6 21/23] drm: rockchip: Add VOP2 driver

2022-02-23 Thread Sascha Hauer
On Thu, Feb 17, 2022 at 04:24:29PM +0300, Dmitry Osipenko wrote: > 17.02.2022 11:29, Sascha Hauer пишет: > > @@ -28,6 +28,12 @@ config ROCKCHIP_VOP > > This selects support for the VOP driver. You should enable it > > on all older SoCs up to RK3399. > > > > +config ROCKCHIP_VOP2 > > +

Re: [PATCH v6 21/23] drm: rockchip: Add VOP2 driver

2022-02-21 Thread Lucas Stach
Hi Andy, Am Montag, dem 21.02.2022 um 19:51 +0800 schrieb Andy Yan: > Hi Sascha: > > On 2/17/22 16:29, Sascha Hauer wrote: > > From: Andy Yan > > > > The VOP2 unit is found on Rockchip SoCs beginning with rk3566/rk3568. > > It replaces the VOP unit found in the older Rockchip SoCs. > > > > Thi

Re: [PATCH v6 21/23] drm: rockchip: Add VOP2 driver

2022-02-21 Thread Andy Yan
Hi Sascha: On 2/17/22 16:29, Sascha Hauer wrote: From: Andy Yan The VOP2 unit is found on Rockchip SoCs beginning with rk3566/rk3568. It replaces the VOP unit found in the older Rockchip SoCs. This driver has been derived from the downstream Rockchip Kernel and heavily modified: - All nonsta

Re: [PATCH v6 21/23] drm: rockchip: Add VOP2 driver

2022-02-19 Thread Dmitry Osipenko
17.02.2022 11:29, Sascha Hauer пишет: > @@ -28,6 +28,12 @@ config ROCKCHIP_VOP > This selects support for the VOP driver. You should enable it > on all older SoCs up to RK3399. > > +config ROCKCHIP_VOP2 > + bool "Rockchip VOP2 driver" > + help > + This selects suppor

Re: [PATCH v6 21/23] drm: rockchip: Add VOP2 driver

2022-02-18 Thread Andy Yan
Hi Sascha: On 2/18/22 16:00, Sascha Hauer wrote: On Fri, Feb 18, 2022 at 11:50:32AM +0800, Andy Yan wrote: Hi Sascha: On 2/17/22 22:06, Heiko Stübner wrote: Am Donnerstag, 17. Februar 2022, 14:58:23 CET schrieb Sascha Hauer: Hi Andy, Please trim the context in your answers to the relevant p

Re: [PATCH v6 21/23] drm: rockchip: Add VOP2 driver

2022-02-18 Thread Sascha Hauer
On Fri, Feb 18, 2022 at 11:50:32AM +0800, Andy Yan wrote: > Hi Sascha: > > On 2/17/22 22:06, Heiko Stübner wrote: > > Am Donnerstag, 17. Februar 2022, 14:58:23 CET schrieb Sascha Hauer: > > > Hi Andy, > > > > > > Please trim the context in your answers to the relevant parts, it makes > > > it eas

Re: [PATCH v6 21/23] drm: rockchip: Add VOP2 driver

2022-02-17 Thread Andy Yan
Hi Sascha: On 2/17/22 22:06, Heiko Stübner wrote: Am Donnerstag, 17. Februar 2022, 14:58:23 CET schrieb Sascha Hauer: Hi Andy, Please trim the context in your answers to the relevant parts, it makes it easier to find the things you said. On Thu, Feb 17, 2022 at 08:00:11PM +0800, Andy Yan wrot

Re: [PATCH v6 21/23] drm: rockchip: Add VOP2 driver

2022-02-17 Thread Heiko Stübner
Am Donnerstag, 17. Februar 2022, 14:58:23 CET schrieb Sascha Hauer: > Hi Andy, > > Please trim the context in your answers to the relevant parts, it makes > it easier to find the things you said. > > On Thu, Feb 17, 2022 at 08:00:11PM +0800, Andy Yan wrote: > > Hi Sascha: > > > > > + > > > + drm

Re: [PATCH v6 21/23] drm: rockchip: Add VOP2 driver

2022-02-17 Thread Sascha Hauer
Hi Andy, Please trim the context in your answers to the relevant parts, it makes it easier to find the things you said. On Thu, Feb 17, 2022 at 08:00:11PM +0800, Andy Yan wrote: > Hi Sascha: > > > + > > + drm_for_each_encoder_mask(encoder, crtc->dev, crtc_state->encoder_mask) > > { > > +

Re: [PATCH v6 21/23] drm: rockchip: Add VOP2 driver

2022-02-17 Thread Andy Yan
Hi Sascha: On 2/17/22 16:29, Sascha Hauer wrote: From: Andy Yan The VOP2 unit is found on Rockchip SoCs beginning with rk3566/rk3568. It replaces the VOP unit found in the older Rockchip SoCs. This driver has been derived from the downstream Rockchip Kernel and heavily modified: - All nonsta

[PATCH v6 21/23] drm: rockchip: Add VOP2 driver

2022-02-17 Thread Sascha Hauer
From: Andy Yan The VOP2 unit is found on Rockchip SoCs beginning with rk3566/rk3568. It replaces the VOP unit found in the older Rockchip SoCs. This driver has been derived from the downstream Rockchip Kernel and heavily modified: - All nonstandard DRM properties have been removed - dropped str