Re: [PATCH v6 2/2] drm/msm/dp: enhance dp controller isr

2023-01-19 Thread Doug Anderson
Hi, On Wed, Jan 18, 2023 at 2:34 PM Stephen Boyd wrote: > > Quoting Doug Anderson (2023-01-18 10:29:59) > > Hi, > > > > On Tue, Dec 27, 2022 at 6:16 PM Kuogee Hsieh > > wrote: > > > + > > > if (isr & DP_INTR_AUX_ERROR) { > > > aux->aux_error_num = DP_AUX_ERR_PHY; > > >

Re: [PATCH v6 2/2] drm/msm/dp: enhance dp controller isr

2023-01-18 Thread Stephen Boyd
Quoting Doug Anderson (2023-01-18 10:29:59) > Hi, > > On Tue, Dec 27, 2022 at 6:16 PM Kuogee Hsieh wrote: > > + > > if (isr & DP_INTR_AUX_ERROR) { > > aux->aux_error_num = DP_AUX_ERR_PHY; > > dp_catalog_aux_clear_hw_interrupts(aux->catalog); > > +

Re: [PATCH v6 2/2] drm/msm/dp: enhance dp controller isr

2023-01-18 Thread Doug Anderson
Hi, On Tue, Dec 27, 2022 at 6:16 PM Kuogee Hsieh wrote: > > dp_display_irq_handler() is the main isr handler with the helps > of two sub isr, dp_aux_isr and dp_ctrl_isr, to service all DP > interrupts on every irq triggered. Current all three isr does > not return IRQ_HANDLED if there are any int

Re: [PATCH v6 2/2] drm/msm/dp: enhance dp controller isr

2023-01-17 Thread Dmitry Baryshkov
On 28/12/2022 04:16, Kuogee Hsieh wrote: dp_display_irq_handler() is the main isr handler with the helps of two sub isr, dp_aux_isr and dp_ctrl_isr, to service all DP interrupts on every irq triggered. Current all three isr does not return IRQ_HANDLED if there are any interrupts it had serviced.

[PATCH v6 2/2] drm/msm/dp: enhance dp controller isr

2022-12-27 Thread Kuogee Hsieh
dp_display_irq_handler() is the main isr handler with the helps of two sub isr, dp_aux_isr and dp_ctrl_isr, to service all DP interrupts on every irq triggered. Current all three isr does not return IRQ_HANDLED if there are any interrupts it had serviced. This patch fix this ambiguity by having all