Re: [PATCH v6 2/2] drm/lima: driver for ARM Mali4xx GPUs

2019-03-05 Thread Dave Airlie
> > > > I don't think you need the _pad fields here, and they're actually a bad > > idea because the lack of checking in your ioctls means you can't trust > > that userspace has initialized them to 0 when you want to redefine them > > as a flags field later. > > Could I drop the _pad? I thought the

Re: [PATCH v6 2/2] drm/lima: driver for ARM Mali4xx GPUs

2019-03-05 Thread Qiang Yu
On Wed, Mar 6, 2019 at 4:16 AM Eric Anholt wrote: > > Qiang Yu writes: > > > - Mali 4xx GPUs have two kinds of processors GP and PP. GP is for > > OpenGL vertex shader processing and PP is for fragment shader > > processing. Each processor has its own MMU so prcessors work in > > virtual ad

Re: [PATCH v6 2/2] drm/lima: driver for ARM Mali4xx GPUs

2019-03-05 Thread Eric Anholt
Qiang Yu writes: > - Mali 4xx GPUs have two kinds of processors GP and PP. GP is for > OpenGL vertex shader processing and PP is for fragment shader > processing. Each processor has its own MMU so prcessors work in > virtual address space. > - There's only one GP but multiple PP (max 4 for