On Mon, Nov 07, 2022 at 12:29:28PM +0100, Noralf Trønnes wrote:
>
>
> Den 07.11.2022 11.21, skrev Maxime Ripard:
> > Hi Noralf,
> >
> > I'll leave aside your comments on the code, since we'll use your
> > implementation.
> >
> > On Sun, Nov 06, 2022 at 05:33:48PM +0100, Noralf Trønnes wrote:
>
Den 07.11.2022 11.21, skrev Maxime Ripard:
> Hi Noralf,
>
> I'll leave aside your comments on the code, since we'll use your
> implementation.
>
> On Sun, Nov 06, 2022 at 05:33:48PM +0100, Noralf Trønnes wrote:
>> Den 26.10.2022 17.33, skrev max...@cerno.tech:
>>> +
>>> + if (cmdline->tv_mo
Den 07.11.2022 11.07, skrev Maxime Ripard:
> Hi Noralf,
>
> On Sun, Nov 06, 2022 at 05:59:23PM +0100, Noralf Trønnes wrote:
>>
>>
>> Den 27.10.2022 00.02, skrev Mateusz Kwiatkowski:
>>> Hi Maxime,
>>>
>>> First of all, nice idea with the helper function that can be reused by
>>> different
>>>
Hi Noralf,
I'll leave aside your comments on the code, since we'll use your implementation.
On Sun, Nov 06, 2022 at 05:33:48PM +0100, Noralf Trønnes wrote:
> Den 26.10.2022 17.33, skrev max...@cerno.tech:
> > +
> > + if (cmdline->tv_mode_specified)
> > + default_mode = cmdline->tv_mod
Hi Noralf,
On Sun, Nov 06, 2022 at 05:59:23PM +0100, Noralf Trønnes wrote:
>
>
> Den 27.10.2022 00.02, skrev Mateusz Kwiatkowski:
> > Hi Maxime,
> >
> > First of all, nice idea with the helper function that can be reused by
> > different
> > drivers. This is neat!
> >
> > But looking at this
Den 27.10.2022 00.02, skrev Mateusz Kwiatkowski:
> Hi Maxime,
>
> First of all, nice idea with the helper function that can be reused by
> different
> drivers. This is neat!
>
> But looking at this function, it feels a bit overcomplicated. You're creating
> the two modes, then checking which
Den 26.10.2022 17.33, skrev max...@cerno.tech:
> Most of the TV connectors will need a similar get_modes implementation
> that will, depending on the drivers' capabilities, register the 480i and
> 576i modes.
>
> That implementation will also need to set the preferred flag and order
> the modes
Hi Mateusz,
On Thu, Oct 27, 2022 at 12:02:24AM +0200, Mateusz Kwiatkowski wrote:
> First of all, nice idea with the helper function that can be reused by
> different drivers. This is neat!
Yeah, it looked to me that given how complex it is, we don't want to
duplicate it in each and every driver.
Hi Maxime,
First of all, nice idea with the helper function that can be reused by different
drivers. This is neat!
But looking at this function, it feels a bit overcomplicated. You're creating
the two modes, then checking which one is the default, then set the preferred
one and possibly reorder t
Most of the TV connectors will need a similar get_modes implementation
that will, depending on the drivers' capabilities, register the 480i and
576i modes.
That implementation will also need to set the preferred flag and order
the modes based on the driver and users preferrence.
This is especiall
10 matches
Mail list logo
