Re: [PATCH v6 1/6] drm/xe/guc: Rename __guc_capture_parsed_output

2025-02-10 Thread Dong, Zhanjun
LGTM Reviewed-by: Zhanjun Dong Regards, Zhanjun Dong On 2025-01-28 1:36 p.m., Alan Previn wrote: Since '__guc_capture_parsed_output *' is a handle that is retrieved, stored and relinquished by an entity external to GuC (i.e. xe_devcoredump), lets rename it to something formal without the'__'

Re: [PATCH v6 1/6] drm/xe/guc: Rename __guc_capture_parsed_output

2025-01-31 Thread Teres Alexis, Alan Previn
> > +++ b/drivers/gpu/drm/xe/xe_guc_capture_snapshot_types.h > > @@ -0,0 +1,53 @@ > > +/* SPDX-License-Identifier: MIT */ > > +/* > > + * Copyright © 2021-2024 Intel Corporation > > 2025 > > then > > Reviewed-by: Rodrigo Vivi > will do - thanks

Re: [PATCH v6 1/6] drm/xe/guc: Rename __guc_capture_parsed_output

2025-01-30 Thread Rodrigo Vivi
On Tue, Jan 28, 2025 at 10:36:47AM -0800, Alan Previn wrote: > Since '__guc_capture_parsed_output *' is a handle that > is retrieved, stored and relinquished by an entity > external to GuC (i.e. xe_devcoredump), lets rename it to > something formal without the'__' prefix and export it > via give a

[PATCH v6 1/6] drm/xe/guc: Rename __guc_capture_parsed_output

2025-01-28 Thread Alan Previn
Since '__guc_capture_parsed_output *' is a handle that is retrieved, stored and relinquished by an entity external to GuC (i.e. xe_devcoredump), lets rename it to something formal without the'__' prefix and export it via give a header file. Signed-off-by: Alan Previn --- drivers/gpu/drm/xe/xe_de