Re: [PATCH v5 7/7] drm/i915: Implement fbdev emulation as in-kernel client

2023-11-01 Thread Thomas Zimmermann
Hi Am 01.11.23 um 10:25 schrieb Ville Syrjälä: On Wed, Nov 01, 2023 at 09:33:41AM +0100, Thomas Zimmermann wrote: Hi Am 25.10.23 um 13:36 schrieb Hogander, Jouni: [...] + +   if (!drm_drv_uses_atomic_modeset(dev)) +   drm_helper_disable_unused_functions(dev); Can you please

Re: [PATCH v5 7/7] drm/i915: Implement fbdev emulation as in-kernel client

2023-11-01 Thread Ville Syrjälä
On Wed, Nov 01, 2023 at 09:33:41AM +0100, Thomas Zimmermann wrote: > Hi > > Am 25.10.23 um 13:36 schrieb Hogander, Jouni: > [...] > >> + > >> +   if (!drm_drv_uses_atomic_modeset(dev)) > >> +   drm_helper_disable_unused_functions(dev); > > > > Can you please explain why this is ne

Re: [PATCH v5 7/7] drm/i915: Implement fbdev emulation as in-kernel client

2023-11-01 Thread Thomas Zimmermann
Hi Am 25.10.23 um 13:36 schrieb Hogander, Jouni: [...] + +   if (!drm_drv_uses_atomic_modeset(dev)) +   drm_helper_disable_unused_functions(dev); Can you please explain why this is needed here? This disables some parts of the mode-setting pipeline and is required for drivers

Re: [PATCH v5 7/7] drm/i915: Implement fbdev emulation as in-kernel client

2023-10-25 Thread Hogander, Jouni
Hi Thomas, couple of minor comments and a question below. On Wed, 2023-09-27 at 12:26 +0200, Thomas Zimmermann wrote: > Replace all code that initializes or releases fbdev emulation > throughout the driver. Instead initialize the fbdev client by a > single call to i915_fbdev_setup() after i915 has

[PATCH v5 7/7] drm/i915: Implement fbdev emulation as in-kernel client

2023-09-27 Thread Thomas Zimmermann
Replace all code that initializes or releases fbdev emulation throughout the driver. Instead initialize the fbdev client by a single call to i915_fbdev_setup() after i915 has registered its DRM device. Just like similar code in other drivers, i915 fbdev emulation now acts as a regular DRM client.