Re: [PATCH v5 6/7] phy: phy-mtk-dp: Add driver for DP phy

2021-10-25 Thread Vinod Koul
On 22-10-21, 15:06, Markus Schneider-Pargmann wrote: > > > + dp_phy->regs = *(struct regmap **)dev->platform_data; > > > + if (!dp_phy->regs) { > > > + dev_err(dev, "No data passed, requires struct regmap**\n"); > > > + return -EINVAL; > > > + } > > > > is there a reason to do it

Re: [PATCH v5 6/7] phy: phy-mtk-dp: Add driver for DP phy

2021-10-22 Thread Markus Schneider-Pargmann
Hi Vinod, On Fri, Oct 22, 2021 at 10:42:30AM +0530, Vinod Koul wrote: > On 21-10-21, 11:27, Markus Schneider-Pargmann wrote: > > This is a new driver that supports the integrated DisplayPort phy for > > mediatek SoCs, especially the mt8195. The phy is integrated into the > > DisplayPort controller

Re: [PATCH v5 6/7] phy: phy-mtk-dp: Add driver for DP phy

2021-10-21 Thread Vinod Koul
On 21-10-21, 11:27, Markus Schneider-Pargmann wrote: > This is a new driver that supports the integrated DisplayPort phy for > mediatek SoCs, especially the mt8195. The phy is integrated into the > DisplayPort controller and will be created by the mtk-dp driver. This > driver expects a struct regma

[PATCH v5 6/7] phy: phy-mtk-dp: Add driver for DP phy

2021-10-21 Thread Markus Schneider-Pargmann
This is a new driver that supports the integrated DisplayPort phy for mediatek SoCs, especially the mt8195. The phy is integrated into the DisplayPort controller and will be created by the mtk-dp driver. This driver expects a struct regmap to be able to work on the same registers as the DisplayPort