Re: [Intel-gfx] [PATCH v5 5/7] drm/i915: Initialize fbdev DRM client with callback functions

2023-11-01 Thread Thomas Zimmermann
Hi Am 01.11.23 um 10:10 schrieb Hogander, Jouni: [...] We are currently working on new driver named as Xe. Due to this it I've always thought that it's an entirely new driver. But I'm not really up-to-date. So the Xe driver is located under i915/ and also shares code with the existing i915 dri

Re: [Intel-gfx] [PATCH v5 5/7] drm/i915: Initialize fbdev DRM client with callback functions

2023-11-01 Thread Hogander, Jouni
On Wed, 2023-11-01 at 09:11 +0100, Thomas Zimmermann wrote: > Hi > > Am 25.10.23 um 10:36 schrieb Hogander, Jouni: > > Hi Thomas, One minor comment inline below. > > Thank you so much for taking the time to review these patches. > > > > > On Wed, 2023-09-27 at 12:26 +0200, Thomas Zimmermann wro

Re: [Intel-gfx] [PATCH v5 5/7] drm/i915: Initialize fbdev DRM client with callback functions

2023-11-01 Thread Thomas Zimmermann
Hi Am 25.10.23 um 10:36 schrieb Hogander, Jouni: Hi Thomas, One minor comment inline below. Thank you so much for taking the time to review these patches. On Wed, 2023-09-27 at 12:26 +0200, Thomas Zimmermann wrote: Initialize i915's fbdev client by giving an instance of struct drm_client_f

Re: [Intel-gfx] [PATCH v5 5/7] drm/i915: Initialize fbdev DRM client with callback functions

2023-10-25 Thread Hogander, Jouni
Hi Thomas, One minor comment inline below. On Wed, 2023-09-27 at 12:26 +0200, Thomas Zimmermann wrote: > Initialize i915's fbdev client by giving an instance of struct > drm_client_funcs to drm_client_init(). Also clean up with > drm_client_release(). > > Doing this in i915 prevents fbdev helpers

[PATCH v5 5/7] drm/i915: Initialize fbdev DRM client with callback functions

2023-09-27 Thread Thomas Zimmermann
Initialize i915's fbdev client by giving an instance of struct drm_client_funcs to drm_client_init(). Also clean up with drm_client_release(). Doing this in i915 prevents fbdev helpers from initializing and releasing the client internally (see drm_fb_helper_init()). No functional change yet; the c