Re: [Intel-gfx] [PATCH v5 4/8] drm: Add driver-private objects to atomic state

2017-03-27 Thread Pandiyan, Dhinakaran
On Mon, 2017-03-27 at 10:35 +0200, Maarten Lankhorst wrote: > Op 27-03-17 om 10:31 schreef Daniel Vetter: > > On Mon, Mar 27, 2017 at 10:28:42AM +0200, Maarten Lankhorst wrote: > >> Op 27-03-17 om 08:38 schreef Daniel Vetter: > >>> On Wed, Mar 22, 2017 at 03:30:49PM -0700, Dhinakaran Pandiyan wrote

Re: [PATCH v5 4/8] drm: Add driver-private objects to atomic state

2017-03-27 Thread Maarten Lankhorst
Op 27-03-17 om 10:31 schreef Daniel Vetter: > On Mon, Mar 27, 2017 at 10:28:42AM +0200, Maarten Lankhorst wrote: >> Op 27-03-17 om 08:38 schreef Daniel Vetter: >>> On Wed, Mar 22, 2017 at 03:30:49PM -0700, Dhinakaran Pandiyan wrote: From: "Pandiyan, Dhinakaran" It is necessary to tr

Re: [PATCH v5 4/8] drm: Add driver-private objects to atomic state

2017-03-27 Thread Daniel Vetter
On Mon, Mar 27, 2017 at 10:28:42AM +0200, Maarten Lankhorst wrote: > Op 27-03-17 om 08:38 schreef Daniel Vetter: > > On Wed, Mar 22, 2017 at 03:30:49PM -0700, Dhinakaran Pandiyan wrote: > >> From: "Pandiyan, Dhinakaran" > >> > >> It is necessary to track states for objects other than connector, cr

Re: [PATCH v5 4/8] drm: Add driver-private objects to atomic state

2017-03-27 Thread Maarten Lankhorst
Op 27-03-17 om 08:38 schreef Daniel Vetter: > On Wed, Mar 22, 2017 at 03:30:49PM -0700, Dhinakaran Pandiyan wrote: >> From: "Pandiyan, Dhinakaran" >> >> It is necessary to track states for objects other than connector, crtc >> and plane for atomic modesets. But adding objects like DP MST link >> b

Re: [PATCH v5 4/8] drm: Add driver-private objects to atomic state

2017-03-26 Thread Daniel Vetter
On Wed, Mar 22, 2017 at 03:30:49PM -0700, Dhinakaran Pandiyan wrote: > From: "Pandiyan, Dhinakaran" > > It is necessary to track states for objects other than connector, crtc > and plane for atomic modesets. But adding objects like DP MST link > bandwidth to drm_atomic_state would mean that a non

Re: [PATCH v5 4/8] drm: Add driver-private objects to atomic state

2017-03-26 Thread Maarten Lankhorst
Hey, There are still 2 unnecessary NULL checks, afaict. Op 22-03-17 om 23:30 schreef Dhinakaran Pandiyan: > From: "Pandiyan, Dhinakaran" > > It is necessary to track states for objects other than connector, crtc > and plane for atomic modesets. But adding objects like DP MST link > bandwidth to

[PATCH v5 4/8] drm: Add driver-private objects to atomic state

2017-03-22 Thread Dhinakaran Pandiyan
From: "Pandiyan, Dhinakaran" It is necessary to track states for objects other than connector, crtc and plane for atomic modesets. But adding objects like DP MST link bandwidth to drm_atomic_state would mean that a non-core object will be modified by the core helper functions for swapping and cle