Re: [PATCH v5 4/6] drm/sprd: add Unisoc's drm display controller driver

2021-05-26 Thread Chunyan Zhang
resend for switching to plain text mode. On Wed, 26 May 2021 at 15:59, Chunyan Zhang wrote: > > Hi Robin, > > On Tue, 18 May 2021 at 00:35, Robin Murphy wrote: >> >> On 2021-05-17 10:27, Joerg Roedel wrote: >> > On Fri, Apr 30, 2021 at 08:20:10PM +0800, Kevin Tang wrote: >> >> Cc Robin & Joerg

Re: [PATCH v5 4/6] drm/sprd: add Unisoc's drm display controller driver

2021-05-26 Thread Chunyan Zhang
Hi Robin, On Tue, 18 May 2021 at 00:35, Robin Murphy wrote: > On 2021-05-17 10:27, Joerg Roedel wrote: > > On Fri, Apr 30, 2021 at 08:20:10PM +0800, Kevin Tang wrote: > >> Cc Robin & Joerg > > > > This is just some GPU internal MMU being used here, it seems. It doesn't > > use the IOMMU core co

Re: [PATCH v5 4/6] drm/sprd: add Unisoc's drm display controller driver

2021-05-18 Thread Maxime Ripard
On Fri, May 14, 2021 at 09:18:00PM +0800, Kevin Tang wrote: > Maxime Ripard 于2021年4月30日周五 下午5:22写道: > > > + info = drm_format_info(fb->format->format); > > > > Here fb->format is the result of drm_format_info(fb->format->format) > > info->num_planes == 3? I will fix it on next version It's no

Re: [PATCH v5 4/6] drm/sprd: add Unisoc's drm display controller driver

2021-05-17 Thread Robin Murphy
On 2021-05-17 10:27, Joerg Roedel wrote: On Fri, Apr 30, 2021 at 08:20:10PM +0800, Kevin Tang wrote: Cc Robin & Joerg This is just some GPU internal MMU being used here, it seems. It doesn't use the IOMMU core code, so no Ack needed from the IOMMU side. Except the actual MMU being used is d

Re: [PATCH v5 4/6] drm/sprd: add Unisoc's drm display controller driver

2021-05-17 Thread Joerg Roedel
On Fri, Apr 30, 2021 at 08:20:10PM +0800, Kevin Tang wrote: > Cc Robin & Joerg This is just some GPU internal MMU being used here, it seems. It doesn't use the IOMMU core code, so no Ack needed from the IOMMU side. Regards, Joerg

Re: [PATCH v5 4/6] drm/sprd: add Unisoc's drm display controller driver

2021-05-14 Thread Kevin Tang
Maxime Ripard 于2021年4月30日周五 下午5:22写道: > > On Sun, Apr 25, 2021 at 08:36:05PM +0800, Kevin Tang wrote: > > Adds DPU(Display Processor Unit) support for the Unisoc's display > > subsystem. > > It's support multi planes, scaler, rotation, PQ(Picture Quality) and more. > > > > v2: > > - Use drm_xxx

Re: [PATCH v5 4/6] drm/sprd: add Unisoc's drm display controller driver

2021-05-11 Thread Chunyan Zhang
On Sun, 25 Apr 2021 at 20:36, Kevin Tang wrote: > > Adds DPU(Display Processor Unit) support for the Unisoc's display > subsystem. > It's support multi planes, scaler, rotation, PQ(Picture Quality) and more. > > v2: > - Use drm_xxx to replace all DRM_XXX. > - Use kzalloc to replace devm_kzallo

Re: [PATCH v5 4/6] drm/sprd: add Unisoc's drm display controller driver

2021-04-30 Thread Kevin Tang
Cc Robin & Joerg Maxime Ripard 于2021年4月30日周五 下午5:22写道: > > On Sun, Apr 25, 2021 at 08:36:05PM +0800, Kevin Tang wrote: > > Adds DPU(Display Processor Unit) support for the Unisoc's display > > subsystem. > > It's support multi planes, scaler, rotation, PQ(Picture Quality) and more. > > > > v2:

Re: [PATCH v5 4/6] drm/sprd: add Unisoc's drm display controller driver

2021-04-30 Thread Maxime Ripard
On Sun, Apr 25, 2021 at 08:36:05PM +0800, Kevin Tang wrote: > Adds DPU(Display Processor Unit) support for the Unisoc's display > subsystem. > It's support multi planes, scaler, rotation, PQ(Picture Quality) and more. > > v2: > - Use drm_xxx to replace all DRM_XXX. > - Use kzalloc to replace d

[PATCH v5 4/6] drm/sprd: add Unisoc's drm display controller driver

2021-04-25 Thread Kevin Tang
Adds DPU(Display Processor Unit) support for the Unisoc's display subsystem. It's support multi planes, scaler, rotation, PQ(Picture Quality) and more. v2: - Use drm_xxx to replace all DRM_XXX. - Use kzalloc to replace devm_kzalloc for sprd_dpu structure init. v3: - Remove dpu_layer stuff l