Re: [PATCH v5 3/3] backlight: lm3630a: add firmware node support

2019-04-24 Thread Dan Murphy
Hello On 4/18/19 10:11 AM, Brian Masney wrote: > Add fwnode support to the lm3630a driver and optionally allow > configuring the label, default brightness level, and maximum brightness > level. The two outputs can be controlled by bank A and B independently > or bank A can control both outputs. >

Re: [PATCH v5 3/3] backlight: lm3630a: add firmware node support

2019-04-24 Thread Dan Murphy
Brian On 4/23/19 11:00 AM, Brian Masney wrote: > On Tue, Apr 23, 2019 at 10:31:41AM -0500, Dan Murphy wrote: >> On 4/23/19 9:01 AM, Brian Masney wrote: >>> On Tue, Apr 23, 2019 at 08:49:20AM -0500, Dan Murphy wrote: > +static int lm3630a_parse_led_sources(struct fwnode_handle *node, > +

Re: [PATCH v5 3/3] backlight: lm3630a: add firmware node support

2019-04-24 Thread Brian Masney
On Tue, Apr 23, 2019 at 10:31:41AM -0500, Dan Murphy wrote: > On 4/23/19 9:01 AM, Brian Masney wrote: > > On Tue, Apr 23, 2019 at 08:49:20AM -0500, Dan Murphy wrote: > >>> +static int lm3630a_parse_led_sources(struct fwnode_handle *node, > >>> + int default_led_sources)

Re: [PATCH v5 3/3] backlight: lm3630a: add firmware node support

2019-04-24 Thread Brian Masney
On Tue, Apr 23, 2019 at 08:49:20AM -0500, Dan Murphy wrote: > > +static int lm3630a_parse_led_sources(struct fwnode_handle *node, > > +int default_led_sources) > > +{ > > + u32 sources[LM3630A_NUM_SINKS]; > > + int ret, num_sources, i; > > + > > + num_sources =

Re: [PATCH v5 3/3] backlight: lm3630a: add firmware node support

2019-04-24 Thread Dan Murphy
Brian On 4/23/19 9:01 AM, Brian Masney wrote: > On Tue, Apr 23, 2019 at 08:49:20AM -0500, Dan Murphy wrote: >>> +static int lm3630a_parse_led_sources(struct fwnode_handle *node, >>> +int default_led_sources) >>> +{ >>> + u32 sources[LM3630A_NUM_SINKS]; >>> + int

[PATCH v5 3/3] backlight: lm3630a: add firmware node support

2019-04-18 Thread Brian Masney
Add fwnode support to the lm3630a driver and optionally allow configuring the label, default brightness level, and maximum brightness level. The two outputs can be controlled by bank A and B independently or bank A can control both outputs. If the platform data was not configured, then the driver