Am 11.07.2018 um 21:19 schrieb Steven Rostedt:
> I just sent the patch. If the printk maintainers take it, then you can
> update the fb driver to set the ignore_console_lock_warning when
> lockless_fb_register is set.
Thank you.
>
> -- Steve
> ___
> dr
Hi,
On (07/11/18 16:46), Thomas Zimmermann wrote:
> Am 28.06.2018 um 11:03 schrieb Hans de Goede:
> > Replace comments about places where the console lock should be held with
> > calls to WARN_CONSOLE_UNLOCKED() to assert that it is actually held.
>
> Debugging fbcon sometimes requires to not tak
Hi,
On 11-07-18 21:19, Steven Rostedt wrote:
On Wed, 11 Jul 2018 19:56:02 +0200
Daniel Vetter wrote:
Have you seen Steven's suggestion which he send about the same time
as your mail I'm replying to here ? I personally think that doing
something like that makes sense (for as long as we have th
On Wed, 11 Jul 2018 19:56:02 +0200
Daniel Vetter wrote:
> > Have you seen Steven's suggestion which he send about the same time
> > as your mail I'm replying to here ? I personally think that doing
> > something like that makes sense (for as long as we have the need
> > for the lockless_fb_regist
On Wed, Jul 11, 2018 at 7:35 PM, Hans de Goede wrote:
> Hi,
>
>
> On 11-07-18 17:42, Daniel Vetter wrote:
>>
>> On Wed, Jul 11, 2018 at 5:35 PM, Hans de Goede
>> wrote:
>>>
>>> Hi,
>>>
>>> On 11-07-18 17:28, Daniel Vetter wrote:
On Wed, Jul 11, 2018 at 5:14 PM, Hans de Goede
Hi,
On 11-07-18 17:42, Daniel Vetter wrote:
On Wed, Jul 11, 2018 at 5:35 PM, Hans de Goede wrote:
Hi,
On 11-07-18 17:28, Daniel Vetter wrote:
On Wed, Jul 11, 2018 at 5:14 PM, Hans de Goede
wrote:
Hi,
On 11-07-18 17:07, Thomas Zimmermann wrote:
Hi
Am 11.07.2018 um 16:52 schrieb Steve
On Wed, Jul 11, 2018 at 5:35 PM, Hans de Goede wrote:
> Hi,
>
> On 11-07-18 17:28, Daniel Vetter wrote:
>>
>> On Wed, Jul 11, 2018 at 5:14 PM, Hans de Goede
>> wrote:
>>>
>>> Hi,
>>>
>>> On 11-07-18 17:07, Thomas Zimmermann wrote:
Hi
Am 11.07.2018 um 16:52 schrieb Steven
On Wed, 11 Jul 2018 17:35:10 +0200
Hans de Goede wrote:
> OK, so if we don't remove it, we should probably make it so that it
> can be used without triggering any WARN_ONs, which would require changing
> the existing WARN_CONSOLE_UNLOCKED() so that the calls from
> drivers/tty/vt/vt.c
> also do
Hi,
On 11-07-18 17:28, Daniel Vetter wrote:
On Wed, Jul 11, 2018 at 5:14 PM, Hans de Goede wrote:
Hi,
On 11-07-18 17:07, Thomas Zimmermann wrote:
Hi
Am 11.07.2018 um 16:52 schrieb Steven Rostedt:
What if you make lockless_register_fb visible to fbcon, and then we can
have a macro:
Th
On Wed, Jul 11, 2018 at 5:14 PM, Hans de Goede wrote:
> Hi,
>
> On 11-07-18 17:07, Thomas Zimmermann wrote:
>>
>> Hi
>>
>> Am 11.07.2018 um 16:52 schrieb Steven Rostedt:
>>>
>>>
>>> What if you make lockless_register_fb visible to fbcon, and then we can
>>> have a macro:
>>
>>
>> There are more of
Hi,
On 11-07-18 17:07, Thomas Zimmermann wrote:
Hi
Am 11.07.2018 um 16:52 schrieb Steven Rostedt:
What if you make lockless_register_fb visible to fbcon, and then we can
have a macro:
There are more of these macro invocations under drivers/tty/vt, which
also mess up the log during debugging
On Wed, Jul 11, 2018 at 5:01 PM, Hans de Goede wrote:
> Hi,
>
> On 11-07-18 16:52, Steven Rostedt wrote:
>>
>> On Wed, 11 Jul 2018 16:46:11 +0200
>> Thomas Zimmermann wrote:
>>
>>> Hi
>>>
>>> Am 28.06.2018 um 11:03 schrieb Hans de Goede:
Replace comments about places where the console l
Hi
Am 11.07.2018 um 16:52 schrieb Steven Rostedt:
>
> What if you make lockless_register_fb visible to fbcon, and then we can
> have a macro:
There are more of these macro invocations under drivers/tty/vt, which
also mess up the log during debugging.
WARN_CONSOLE_UNLOCKED is already protected b
Hi,
On 11-07-18 16:52, Steven Rostedt wrote:
On Wed, 11 Jul 2018 16:46:11 +0200
Thomas Zimmermann wrote:
Hi
Am 28.06.2018 um 11:03 schrieb Hans de Goede:
Replace comments about places where the console lock should be held with
calls to WARN_CONSOLE_UNLOCKED() to assert that it is actually h
On Wed, 11 Jul 2018 16:46:11 +0200
Thomas Zimmermann wrote:
> Hi
>
> Am 28.06.2018 um 11:03 schrieb Hans de Goede:
> > Replace comments about places where the console lock should be held with
> > calls to WARN_CONSOLE_UNLOCKED() to assert that it is actually held.
>
> Debugging fbcon sometime
Hi
Am 28.06.2018 um 11:03 schrieb Hans de Goede:
> Replace comments about places where the console lock should be held with
> calls to WARN_CONSOLE_UNLOCKED() to assert that it is actually held.
Debugging fbcon sometimes requires to not take the console lock. This
patch breaks the debugging worka
Replace comments about places where the console lock should be held with
calls to WARN_CONSOLE_UNLOCKED() to assert that it is actually held.
Acked-by: Steven Rostedt (VMware)
Reviewed-by: Daniel Vetter
Reviewed-by: Sergey Senozhatsky
Signed-off-by: Hans de Goede
---
Changes in v3:
-New patch
17 matches
Mail list logo
