Re: [PATCH v5 2/3] drm/sched: Adjust outdated docu for run_job()

2025-03-04 Thread Philipp Stanner
On Tue, 2025-03-04 at 10:05 +0100, Christian König wrote: > Am 24.02.25 um 17:25 schrieb Matthew Brost: > > On Mon, Feb 24, 2025 at 03:43:49PM +0100, Danilo Krummrich wrote: > > > On Mon, Feb 24, 2025 at 10:29:26AM -0300, Maíra Canal wrote: > > > > On 20/02/25 12:28, Philipp Stanner wrote: > > > >

Re: [PATCH v5 2/3] drm/sched: Adjust outdated docu for run_job()

2025-03-04 Thread Christian König
Am 24.02.25 um 17:25 schrieb Matthew Brost: > On Mon, Feb 24, 2025 at 03:43:49PM +0100, Danilo Krummrich wrote: >> On Mon, Feb 24, 2025 at 10:29:26AM -0300, Maíra Canal wrote: >>> On 20/02/25 12:28, Philipp Stanner wrote: On Thu, 2025-02-20 at 10:28 -0300, Maíra Canal wrote: > Would it be

Re: [PATCH v5 2/3] drm/sched: Adjust outdated docu for run_job()

2025-02-24 Thread Matthew Brost
On Mon, Feb 24, 2025 at 03:43:49PM +0100, Danilo Krummrich wrote: > On Mon, Feb 24, 2025 at 10:29:26AM -0300, Maíra Canal wrote: > > On 20/02/25 12:28, Philipp Stanner wrote: > > > On Thu, 2025-02-20 at 10:28 -0300, Maíra Canal wrote: > > > > Would it be possible to add a comment that `run_job()` m

Re: [PATCH v5 2/3] drm/sched: Adjust outdated docu for run_job()

2025-02-24 Thread Danilo Krummrich
On Mon, Feb 24, 2025 at 10:29:26AM -0300, Maíra Canal wrote: > On 20/02/25 12:28, Philipp Stanner wrote: > > On Thu, 2025-02-20 at 10:28 -0300, Maíra Canal wrote: > > > Would it be possible to add a comment that `run_job()` must check if > > > `s_fence->finished.error` is different than 0? If you i

Re: [PATCH v5 2/3] drm/sched: Adjust outdated docu for run_job()

2025-02-24 Thread Maíra Canal
Hi Philipp, On 20/02/25 12:28, Philipp Stanner wrote: On Thu, 2025-02-20 at 10:28 -0300, Maíra Canal wrote: Hi Philipp, On 20/02/25 08:28, Philipp Stanner wrote: The documentation for drm_sched_backend_ops.run_job() mentions a certain function called drm_sched_job_recovery(). This function do

Re: [PATCH v5 2/3] drm/sched: Adjust outdated docu for run_job()

2025-02-20 Thread Philipp Stanner
On Thu, 2025-02-20 at 10:28 -0300, Maíra Canal wrote: > Hi Philipp, > > On 20/02/25 08:28, Philipp Stanner wrote: > > The documentation for drm_sched_backend_ops.run_job() mentions a > > certain > > function called drm_sched_job_recovery(). This function does not > > exist. > > What's actually mea

Re: [PATCH v5 2/3] drm/sched: Adjust outdated docu for run_job()

2025-02-20 Thread Maíra Canal
Hi Philipp, On 20/02/25 08:28, Philipp Stanner wrote: The documentation for drm_sched_backend_ops.run_job() mentions a certain function called drm_sched_job_recovery(). This function does not exist. What's actually meant is drm_sched_resubmit_jobs(), which is by now also deprecated. Remove the

[PATCH v5 2/3] drm/sched: Adjust outdated docu for run_job()

2025-02-20 Thread Philipp Stanner
The documentation for drm_sched_backend_ops.run_job() mentions a certain function called drm_sched_job_recovery(). This function does not exist. What's actually meant is drm_sched_resubmit_jobs(), which is by now also deprecated. Remove the mention of the removed function. Discourage the behavior