Re: [PATCH v5 2/2] drm/panel: Add driver for Novatek NT36523

2023-03-14 Thread Jianhua Lu
On Mon, Mar 13, 2023 at 07:53:30PM +0100, Sam Ravnborg wrote: > On Mon, Mar 13, 2023 at 09:06:50AM +0100, Neil Armstrong wrote: > > On 11/03/2023 13:46, Jianhua Lu wrote: > > > On Sat, Mar 11, 2023 at 01:38:52PM +0100, Konrad Dybcio wrote: > > > > > > > > > > > > On 11.03.2023 13:32, Jianhua Lu w

Re: [PATCH v5 2/2] drm/panel: Add driver for Novatek NT36523

2023-03-13 Thread Sam Ravnborg
On Mon, Mar 13, 2023 at 09:06:50AM +0100, Neil Armstrong wrote: > On 11/03/2023 13:46, Jianhua Lu wrote: > > On Sat, Mar 11, 2023 at 01:38:52PM +0100, Konrad Dybcio wrote: > > > > > > > > > On 11.03.2023 13:32, Jianhua Lu wrote: > > > > Add a driver for panels using the Novatek NT36523 display dr

Re: [PATCH v5 2/2] drm/panel: Add driver for Novatek NT36523

2023-03-13 Thread Jianhua Lu
On Mon, Mar 13, 2023 at 09:06:50AM +0100, Neil Armstrong wrote: > On 11/03/2023 13:46, Jianhua Lu wrote: > > On Sat, Mar 11, 2023 at 01:38:52PM +0100, Konrad Dybcio wrote: > >> > >> > >> On 11.03.2023 13:32, Jianhua Lu wrote: > >>> Add a driver for panels using the Novatek NT36523 display driver IC

Re: [PATCH v5 2/2] drm/panel: Add driver for Novatek NT36523

2023-03-13 Thread Neil Armstrong
On 11/03/2023 13:46, Jianhua Lu wrote: On Sat, Mar 11, 2023 at 01:38:52PM +0100, Konrad Dybcio wrote: On 11.03.2023 13:32, Jianhua Lu wrote: Add a driver for panels using the Novatek NT36523 display driver IC. Signed-off-by: Jianhua Lu --- [...] + +static int nt36523_get_modes(struct drm

Re: [PATCH v5 2/2] drm/panel: Add driver for Novatek NT36523

2023-03-11 Thread Jianhua Lu
On Sat, Mar 11, 2023 at 01:38:52PM +0100, Konrad Dybcio wrote: > > > On 11.03.2023 13:32, Jianhua Lu wrote: > > Add a driver for panels using the Novatek NT36523 display driver IC. > > > > Signed-off-by: Jianhua Lu > > --- > [...] > > > + > > +static int nt36523_get_modes(struct drm_panel *pan

Re: [PATCH v5 2/2] drm/panel: Add driver for Novatek NT36523

2023-03-11 Thread Konrad Dybcio
On 11.03.2023 13:32, Jianhua Lu wrote: > Add a driver for panels using the Novatek NT36523 display driver IC. > > Signed-off-by: Jianhua Lu > --- [...] > + > +static int nt36523_get_modes(struct drm_panel *panel, > +struct drm_connector *connector) > +{ > + str

[PATCH v5 2/2] drm/panel: Add driver for Novatek NT36523

2023-03-11 Thread Jianhua Lu
Add a driver for panels using the Novatek NT36523 display driver IC. Signed-off-by: Jianhua Lu --- Changes in v5: - use lowercase hex for init sequence - fix code style - enable DRM_MODE_TYPE_PREFERRED if where is only one mode. Changes in v4: - add multiple modes support - use dev_err