Re: [PATCH v5 18/44] drm/vc4: hdmi: Create destroy state implementation

2023-12-14 Thread Maxime Ripard
Hi Dave, On Tue, Dec 12, 2023 at 11:40:26AM +, Dave Stevenson wrote: > On Thu, 7 Dec 2023 at 15:50, Maxime Ripard wrote: > > > > Even though we were rolling our own custom state for the vc4 HDMI > > controller driver, we were still using the generic helper to destroy > > that state. > > > > I

Re: (subset) [PATCH v5 18/44] drm/vc4: hdmi: Create destroy state implementation

2023-12-13 Thread Maxime Ripard
On Thu, 07 Dec 2023 16:49:41 +0100, Maxime Ripard wrote: > Even though we were rolling our own custom state for the vc4 HDMI > controller driver, we were still using the generic helper to destroy > that state. > > It was mostly working since the underlying state is the first member of > our state

Re: [PATCH v5 18/44] drm/vc4: hdmi: Create destroy state implementation

2023-12-12 Thread Dave Stevenson
On Thu, 7 Dec 2023 at 15:50, Maxime Ripard wrote: > > Even though we were rolling our own custom state for the vc4 HDMI > controller driver, we were still using the generic helper to destroy > that state. > > It was mostly working since the underlying state is the first member of > our state so th

[PATCH v5 18/44] drm/vc4: hdmi: Create destroy state implementation

2023-12-07 Thread Maxime Ripard
Even though we were rolling our own custom state for the vc4 HDMI controller driver, we were still using the generic helper to destroy that state. It was mostly working since the underlying state is the first member of our state so the pointers are probably equal in all relevant cases, but it's st