Re: Re: Re: [PATCH v5 15/44] drm/connector: hdmi: Compute bpc and format automatically

2024-02-02 Thread Jani Nikula
On Thu, 01 Feb 2024, Maxime Ripard wrote: > We've discussed that on IRC today. I'm not sure there was a conclusion > other than "well this doesn't seem right". I think we should at least > provide different EDIDs depending on the connector type indeed, but > there was also a few discussions that a

Re: Re: Re: [PATCH v5 15/44] drm/connector: hdmi: Compute bpc and format automatically

2024-02-01 Thread Maxime Ripard
On Thu, Feb 01, 2024 at 03:33:24PM +, Dave Stevenson wrote: > Hi Maxime > > On Thu, 1 Feb 2024 at 12:51, Maxime Ripard wrote: > > > > On Thu, Dec 14, 2023 at 03:10:43PM +, Dave Stevenson wrote: > > > > +static bool > > > > +sink_supports_format_bpc(const struct drm_connector *connector, >

Re: Re: [PATCH v5 15/44] drm/connector: hdmi: Compute bpc and format automatically

2024-02-01 Thread Dave Stevenson
Hi Maxime On Thu, 1 Feb 2024 at 12:51, Maxime Ripard wrote: > > On Thu, Dec 14, 2023 at 03:10:43PM +, Dave Stevenson wrote: > > > +static bool > > > +sink_supports_format_bpc(const struct drm_connector *connector, > > > +const struct drm_display_info *info, > > > +

Re: Re: [PATCH v5 15/44] drm/connector: hdmi: Compute bpc and format automatically

2024-02-01 Thread Maxime Ripard
On Thu, Dec 14, 2023 at 03:10:43PM +, Dave Stevenson wrote: > > +static bool > > +sink_supports_format_bpc(const struct drm_connector *connector, > > +const struct drm_display_info *info, > > +const struct drm_display_mode *mode, > > +

Re: [PATCH v5 15/44] drm/connector: hdmi: Compute bpc and format automatically

2023-12-14 Thread Dave Stevenson
Hi Maxime On Thu, 7 Dec 2023 at 15:50, Maxime Ripard wrote: > > Now that we have all the infrastructure needed, we can add some code > that will, for a given connector state and mode, compute the best output > format and bpc. > > The algorithm is the same one than the one already found in i915 an

[PATCH v5 15/44] drm/connector: hdmi: Compute bpc and format automatically

2023-12-07 Thread Maxime Ripard
Now that we have all the infrastructure needed, we can add some code that will, for a given connector state and mode, compute the best output format and bpc. The algorithm is the same one than the one already found in i915 and vc4. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/drm_atomic_sta