[PATCH v5 10/12] drm/i915: Defer probe if gmux is present but its driver isn't

2016-02-19 Thread Daniel Vetter
On Thu, Feb 18, 2016 at 11:20 PM, Lukas Wunner wrote: > Hi, > > On Thu, Feb 18, 2016 at 10:39:05PM +0100, Daniel Vetter wrote: >> On Thu, Feb 18, 2016 at 9:34 PM, Lukas Wunner wrote: >> > >> >> Ok, makes sense. I still think adding the check to the client_register >> >> function would be good, ju

[PATCH v5 10/12] drm/i915: Defer probe if gmux is present but its driver isn't

2016-02-18 Thread Deucher, Alexander
> Deucher, Alexander > Subject: Re: [PATCH v5 10/12] drm/i915: Defer probe if gmux is present but > its driver isn't > > On Thu, Feb 18, 2016 at 11:20 PM, Lukas Wunner wrote: > > Hi, > > > > On Thu, Feb 18, 2016 at 10:39:05PM +0100, Daniel Vetter wrote:

[PATCH v5 10/12] drm/i915: Defer probe if gmux is present but its driver isn't

2016-02-18 Thread Lukas Wunner
Hi, On Thu, Feb 18, 2016 at 10:39:05PM +0100, Daniel Vetter wrote: > On Thu, Feb 18, 2016 at 9:34 PM, Lukas Wunner wrote: > > > >> Ok, makes sense. I still think adding the check to the client_register > >> function would be good, just as a safety measure. > > > > Hm, the idea of calling vga_swit

[PATCH v5 10/12] drm/i915: Defer probe if gmux is present but its driver isn't

2016-02-18 Thread Daniel Vetter
On Thu, Feb 18, 2016 at 9:34 PM, Lukas Wunner wrote: > >> Ok, makes sense. I still think adding the check to the client_register >> function would be good, just as a safety measure. > > Hm, the idea of calling vga_switcheroo_client_probe_defer() twice > causes me pain in the stomach. It's surprisi

[PATCH v5 10/12] drm/i915: Defer probe if gmux is present but its driver isn't

2016-02-18 Thread Lukas Wunner
Hi, On Tue, Feb 16, 2016 at 05:08:40PM +0100, Daniel Vetter wrote: > On Tue, Feb 16, 2016 at 04:58:20PM +0100, Lukas Wunner wrote: > > On Sun, Feb 14, 2016 at 01:46:28PM +0100, Daniel Vetter wrote: > > > On Sun, Feb 14, 2016 at 1:10 PM, Lukas Wunner wrote: > > > > + * DRM drivers should invoke th

[PATCH v5 10/12] drm/i915: Defer probe if gmux is present but its driver isn't

2016-02-16 Thread Daniel Vetter
On Tue, Feb 16, 2016 at 04:58:20PM +0100, Lukas Wunner wrote: > Hi, > > On Sun, Feb 14, 2016 at 01:46:28PM +0100, Daniel Vetter wrote: > > On Sun, Feb 14, 2016 at 1:10 PM, Lukas Wunner wrote: > > > /** > > > + * vga_switcheroo_client_probe_defer() - whether to defer probing a > > > given GPU >

[PATCH v5 10/12] drm/i915: Defer probe if gmux is present but its driver isn't

2016-02-16 Thread Lukas Wunner
Hi, On Sun, Feb 14, 2016 at 01:46:28PM +0100, Daniel Vetter wrote: > On Sun, Feb 14, 2016 at 1:10 PM, Lukas Wunner wrote: > > /** > > + * vga_switcheroo_client_probe_defer() - whether to defer probing a given > > GPU > > + * @pdev: pci device of GPU > > + * > > + * Determine whether any prerequ

[PATCH v5 10/12] drm/i915: Defer probe if gmux is present but its driver isn't

2016-02-14 Thread Daniel Vetter
On Sun, Feb 14, 2016 at 1:10 PM, Lukas Wunner wrote: > /** > + * vga_switcheroo_client_probe_defer() - whether to defer probing a given GPU > + * @pdev: pci device of GPU > + * > + * Determine whether any prerequisites are not fulfilled to probe a given > GPU. I'd phrase this as "Determine whet

[PATCH v5 10/12] drm/i915: Defer probe if gmux is present but its driver isn't

2016-02-14 Thread Lukas Wunner
Hi, On Tue, Feb 09, 2016 at 10:04:01AM +0100, Daniel Vetter wrote: > On Mon, Jan 11, 2016 at 08:09:20PM +0100, Lukas Wunner wrote: [...] > > @@ -967,6 +970,15 @@ static int i915_pci_probe(struct pci_dev *pdev, const > > struct pci_device_id *ent) > > if (PCI_FUNC(pdev->devfn)) > >

[PATCH v5 10/12] drm/i915: Defer probe if gmux is present but its driver isn't

2016-02-09 Thread Daniel Vetter
On Mon, Jan 11, 2016 at 08:09:20PM +0100, Lukas Wunner wrote: > gmux is a microcontroller built into dual GPU MacBook Pros. > On pre-retina MBPs, if we're the inactive GPU, we need apple-gmux > to temporarily switch DDC so that we can probe the panel's EDID. > > The checks for CONFIG_VGA_ARB and C

[PATCH v5 10/12] drm/i915: Defer probe if gmux is present but its driver isn't

2016-01-11 Thread Lukas Wunner
gmux is a microcontroller built into dual GPU MacBook Pros. On pre-retina MBPs, if we're the inactive GPU, we need apple-gmux to temporarily switch DDC so that we can probe the panel's EDID. The checks for CONFIG_VGA_ARB and CONFIG_VGA_SWITCHEROO are necessary because if either of them is disabled