[PATCH v5 1/3] drm/rockchip: Add basic drm driver

2014-09-26 Thread Mark yao
On 2014?09?25? 20:11, Mark yao wrote: > On 2014?09?25? 16:58, Mark yao wrote: >> On 2014?09?25? 00:20, Daniel Kurtz wrote: >>> Hi Mark, >>> >>> Please review comments inline... >>> >>> On Wed, Sep 24, 2014 at 10:12 AM, Mark yao >>> wrote: >>> To match the enum name, use ROCKCHIP_OUTPUT_TYPE_*. >>

[PATCH v5 1/3] drm/rockchip: Add basic drm driver

2014-09-25 Thread Mark yao
On 2014?09?25? 16:58, Mark yao wrote: > On 2014?09?25? 00:20, Daniel Kurtz wrote: >> Hi Mark, >> >> Please review comments inline... >> >> On Wed, Sep 24, 2014 at 10:12 AM, Mark yao >> wrote: >> To match the enum name, use ROCKCHIP_OUTPUT_TYPE_*. >> Also, no need to explicitly set the first one t

[PATCH v5 1/3] drm/rockchip: Add basic drm driver

2014-09-25 Thread Rob Clark
On Tue, Sep 23, 2014 at 10:12 PM, Mark yao wrote: > This patch adds the basic structure of a DRM Driver for Rockchip Socs. > > Signed-off-by: Mark yao Looks like my comments are addressed, so: Reviewed-by: Rob Clark > --- > Changes in v2: > - use the component framework to defer main drm driv

[PATCH v5 1/3] drm/rockchip: Add basic drm driver

2014-09-25 Thread Mark yao
On 2014?09?25? 00:20, Daniel Kurtz wrote: > Hi Mark, > > Please review comments inline... > > On Wed, Sep 24, 2014 at 10:12 AM, Mark yao wrote: >> This patch adds the basic structure of a DRM Driver for Rockchip Socs. >> >> Signed-off-by: Mark yao >> --- >> Changes in v2: >> - use the component f

[PATCH v5 1/3] drm/rockchip: Add basic drm driver

2014-09-25 Thread Daniel Kurtz
Hi Mark, Please review comments inline... On Wed, Sep 24, 2014 at 10:12 AM, Mark yao wrote: > This patch adds the basic structure of a DRM Driver for Rockchip Socs. > > Signed-off-by: Mark yao > --- > Changes in v2: > - use the component framework to defer main drm driver probe > until all VO

[PATCH v5 1/3] drm/rockchip: Add basic drm driver

2014-09-24 Thread Mark yao
This patch adds the basic structure of a DRM Driver for Rockchip Socs. Signed-off-by: Mark yao --- Changes in v2: - use the component framework to defer main drm driver probe until all VOP devices have been probed. - use dma-mapping API with ARM_DMA_USE_IOMMU, create dma mapping by master dev