Re: [PATCH v5 1/2] drm/panel: Add support for Truly NT35597 panel

2018-08-10 Thread Linus Walleij
On Thu, Aug 9, 2018 at 12:53 PM Thierry Reding wrote: [Me] > > I suspect this is indeed a panel driver and not a panel with integrated > > driver. I think the best is to define two compatible strings like > > we do for ILI9322: > > "truly,nt35597", "qcom,reference-design-name-display"; > > I don'

Re: [PATCH v5 1/2] drm/panel: Add support for Truly NT35597 panel

2018-08-09 Thread abhinavk
Hi Thierry/Sean Thanks for your comments. Yes, I agree with you as well at the moment the generic "truly,nt35597" string doesnt have enough information to support multiple panels. I am more comfortable renaming the compatible to "qcom,sdm845-mtp-2k-display" as we have all the pieces needed f

Re: [PATCH v5 1/2] drm/panel: Add support for Truly NT35597 panel

2018-08-09 Thread Sean Paul
On Thu, Aug 09, 2018 at 12:53:49PM +0200, Thierry Reding wrote: > On Fri, Aug 03, 2018 at 01:03:45PM +0200, Linus Walleij wrote: > > On Fri, Aug 3, 2018 at 4:49 AM Abhinav Kumar > > wrote: > > > > Hi Abhinav, > > > > > From: "abhin...@codeaurora.org" > > > > > > Add support for Truly NT35597 p

Re: [PATCH v5 1/2] drm/panel: Add support for Truly NT35597 panel

2018-08-09 Thread Thierry Reding
On Fri, Aug 03, 2018 at 01:03:45PM +0200, Linus Walleij wrote: > On Fri, Aug 3, 2018 at 4:49 AM Abhinav Kumar wrote: > > Hi Abhinav, > > > From: "abhin...@codeaurora.org" > > > > Add support for Truly NT35597 panel used > > in MSM reference platforms. > > > > This panel supports both single DSI

Re: [PATCH v5 1/2] drm/panel: Add support for Truly NT35597 panel

2018-08-03 Thread abhinavk
Hi Linus Thanks for your valuable comments. We agree with your ideas and will address them. Some details below on how we will address them. Thanks Abhinav On 2018-08-03 04:03, Linus Walleij wrote: On Fri, Aug 3, 2018 at 4:49 AM Abhinav Kumar wrote: Hi Abhinav, From: "abhin...@codeaurora

Re: [PATCH v5 1/2] drm/panel: Add support for Truly NT35597 panel

2018-08-03 Thread kbuild test robot
Hi abhinavk, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v4.18-rc7 next-20180802] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-

Re: [PATCH v5 1/2] drm/panel: Add support for Truly NT35597 panel

2018-08-03 Thread Linus Walleij
On Fri, Aug 3, 2018 at 4:49 AM Abhinav Kumar wrote: Hi Abhinav, > From: "abhin...@codeaurora.org" > > Add support for Truly NT35597 panel used > in MSM reference platforms. > > This panel supports both single DSI and dual DSI > modes. > > However, this patch series adds support only for > dual

[PATCH v5 1/2] drm/panel: Add support for Truly NT35597 panel

2018-08-02 Thread Abhinav Kumar
From: "abhin...@codeaurora.org" Add support for Truly NT35597 panel used in MSM reference platforms. This panel supports both single DSI and dual DSI modes. However, this patch series adds support only for dual DSI mode. Changes in v5: - Added comments for the delays - Fix error messages and r

[PATCH v5 1/2] drm/panel: Add support for Truly NT35597 panel

2018-08-02 Thread Abhinav Kumar
From: "abhin...@codeaurora.org" Add support for Truly NT35597 panel used in MSM reference platforms. This panel supports both single DSI and dual DSI modes. However, this patch series adds support only for dual DSI mode. Changes in v5: - Added comments for the delays - Fix error messages and r