-misc-next
patch link:
https://lore.kernel.org/r/20240728152858.346211-2-sui.jingfeng%40linux.dev
patch subject: [PATCH v5 1/2] drm/loongson: Introduce component framework
support
config: mips-randconfig-r111-20240802
(https://download.01.org/0day-ci/archive/20240803/202408031152.pavm0tor-...
>> …
>>> +++ b/drivers/gpu/drm/loongson/loongson_drv.h
>>> @@ -0,0 +1,108 @@
>> …
>>> +#ifndef __LOONGSON_DRV_H__
>>> +#define __LOONGSON_DRV_H__
>> …
>>
>> I suggest to omit leading underscores from such identifiers.
…
> I suggest add this rules to the checkpatch.pl script,
…
I hope that you woul
Hi,
On 2024/7/29 14:40, Markus Elfring wrote:
…
+++ b/drivers/gpu/drm/loongson/loongson_drv.h
@@ -0,0 +1,108 @@
…
+#ifndef __LOONGSON_DRV_H__
+#define __LOONGSON_DRV_H__
…
I suggest to omit leading underscores from such identifiers.
https://wiki.sei.cmu.edu/confluence/display/c/DCL37-C.+Do
Hi,
On 2024/7/29 15:37, Markus Elfring wrote:
…
+++ b/drivers/gpu/drm/loongson/loongson_drv.c
@@ -0,0 +1,298 @@
…
+static int loongson_drm_driver_probe(struct platform_device *pdev)
+{
…
+ dev_info(&pdev->dev, "probed\n");
…
+}
…
Do you find such information really relevant?
T
…
> +++ b/drivers/gpu/drm/loongson/loongson_drv.c
> @@ -0,0 +1,298 @@
…
> +static int loongson_drm_driver_probe(struct platform_device *pdev)
> +{
…
> + dev_info(&pdev->dev, "probed\n");
…
> +}
…
Do you find such information really relevant?
Regards,
Markus
…
> +++ b/drivers/gpu/drm/loongson/loongson_drv.h
> @@ -0,0 +1,108 @@
…
> +#ifndef __LOONGSON_DRV_H__
> +#define __LOONGSON_DRV_H__
…
I suggest to omit leading underscores from such identifiers.
https://wiki.sei.cmu.edu/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier
…
> +++ b/drivers/gpu/drm/loongson/loongson_drv.c
> @@ -0,0 +1,298 @@
…
> +static int loongson_drm_freeze(struct drm_device *ddev)
> +{
…
> + /* unpin all of buffers in the VRAM */
> + mutex_lock(&ldrm->gem.mutex);
…
> + mutex_unlock(&ldrm->gem.mutex);
> +
> + lsdc_bo_evict_vram(dde
In some display subsystems, the functionality of a PCIe device might be
too complex to manage with a single driver. A split of the functionality
into child devices can help to achieve better modularity. For example,
KMS drivers who have dependencies on external modules will suffer from
the deferral
